Page MenuHomeSoftware Heritage

backfill: Add support for directories with duplicated entries
ClosedPublic

Authored by vlorentz on Jul 6 2022, 1:37 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rDSTOcfc867999d9d: backfill: Add support for directories with duplicated entries
Summary

This uses Directory.from_possibly_duplicated_entries() to mangle entry names
instead of crashing.

Depends on D8080.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8081 (id=29180)

Rebasing onto 47caf04ea5...

Current branch diff-target is up to date.
Changes applied before test
commit e727b8a6c3efda1c43b95c93617cc6145b0a9dac
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 6 13:37:00 2022 +0200

    backfill: Add support for directories with duplicated entries
    
    This uses Directory.from_possibly_duplicated_entries() to mangle entry names
    instead of crashing.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1628/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1628/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2022, 1:37 PM
Harbormaster failed remote builds in B30269: Diff 29180!
ardumont added inline comments.
swh/storage/tests/test_backfill.py
352

it's the Directory.from_possibly_duplicated_entries which does the renaming, isn't it?

Assuming the build it depends on is landed, tagged and released and this build goes green.

This revision is now accepted and ready to land.Jul 8 2022, 10:04 AM

Assuming the build it depends on is landed, tagged and released and this build goes green.

yes

swh/storage/tests/test_backfill.py
352

yes

vlorentz added a task: Restricted Maniphest Task.Jul 12 2022, 2:11 PM

Build is green

Patch application report for D8081 (id=29180)

Rebasing onto d6db4e4453...

First, rewinding head to replay your work on top of it...
Applying: backfill: Add support for directories with duplicated entries
Changes applied before test
commit fa6ed65d40a750af1235c2ce01c40dec1db3aaf5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 6 13:37:00 2022 +0200

    backfill: Add support for directories with duplicated entries
    
    This uses Directory.from_possibly_duplicated_entries() to mangle entry names
    instead of crashing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1632/ for more details.

Build is green

Patch application report for D8081 (id=29310)

Rebasing onto d6db4e4453...

Current branch diff-target is up to date.
Changes applied before test
commit cfc867999d9df6511380ba59c81ae10370496543
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 6 13:37:00 2022 +0200

    backfill: Add support for directories with duplicated entries
    
    This uses Directory.from_possibly_duplicated_entries() to mangle entry names
    instead of crashing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1633/ for more details.