We already have 'msgpack >= 1.0.0' in requirements.txt
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCOREd0e7f5a10e46: Remove unused fallbacks for old msgpack version
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D8075 (id=29146)
Rebasing onto 87e7afab11...
First, rewinding head to replay your work on top of it... Applying: Remove unused fallbacks for old msgpack version
Changes applied before test
commit 1f3f579dcafd5a8aba519918bafb78446afad5e2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jul 4 15:03:27 2022 +0200
Remove unused fallbacks for old msgpack version
We already have 'msgpack >= 1.0.0' in requirements.txtSee https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/455/ for more details.
Comment Actions
Build is green
Patch application report for D8075 (id=29147)
Rebasing onto 87e7afab11...
Current branch diff-target is up to date.
Changes applied before test
commit d0e7f5a10e4628e861ac1541977592a4612aca7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jul 4 15:03:27 2022 +0200
Remove unused fallbacks for old msgpack version
We already have 'msgpack >= 1.0.0' in requirements.txtSee https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/456/ for more details.
Comment Actions
lgtm
Workers which are running on buster [1] seems ok indeed so fine i guess.
ardumont@worker07:~% dpkg -l python3-msgpack | grep ii ii python3-msgpack 1.0.0-6~bpo10+1 amd64 Python 3 implementation of MessagePack format
[1] well machines which are running swh services in general are buster ones... (rpc services)