Differential D8003

utils: Ensure to return correct revision in parse_external_definition
ClosedPublic
Actions

Authored by anlambert on Jun 17 2022, 12:06 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN651e2964eeb3: utils: Ensure to return correct revision in parse_external_definition

Summary

An external definition can be of the following form (where XXX and YYY
are revision numbers):

-r XXX <repo_url>@YYY

In that case, the official subversion client will export the revision
XXX of the external repository.

So ensure to have the same behavior when the subversion loader processes
a repository with such external defintion in it.

Related sentry issue: SWH-LOADER-SVN-2Y

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 17 2022, 12:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 17 2022, 12:06 PM

Build is green

Patch application report for D8003 (id=28839)

Rebasing onto 670365596e...

Current branch diff-target is up to date.

Changes applied before test

commit 651e2964eeb3c0dc3c691973bd26c6495593176d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jun 17 12:01:36 2022 +0200

    utils: Ensure to return correct revision in parse_external_definition
    
    An external definition can be of the following form (where XXX and YYY
    are revision numbers):
    
            -r XXX <repo_url>@YYY
    
    In that case, the official subversion client will export the revision
    XXX of the external repository.
    
    So ensure to have the same behavior when the subversion loader processes
    a repository with such external defintion in it.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/333/ for more details.

Harbormaster completed remote builds in B29924: Diff 28839.Jun 17 2022, 12:09 PM

anlambert requested review of this revision.Jun 17 2022, 12:09 PM

ardumont accepted this revision.Jun 18 2022, 4:11 PM

This revision is now accepted and ready to land.Jun 18 2022, 4:11 PM

Closed by commit rDLDSVN651e2964eeb3: utils: Ensure to return correct revision in parse_external_definition (authored by anlambert). · Explain WhyJun 20 2022, 3:43 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN651e2964eeb3: utils: Ensure to return correct revision in parse_external_definition.