Page MenuHomeSoftware Heritage

Refactor origin connection functional tests
ClosedPublic

Authored by jayeshv on Tue, Jun 14, 3:05 PM.

Diff Detail

Repository
rDGQL GraphQL API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7989 (id=28779)

Rebasing onto 67e0bf7370...

Current branch diff-target is up to date.
Changes applied before test
commit 00e3e5cabe2fbd85e8e9d32ab923c047321e51f9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 15:04:14 2022 +0200

    Refactor origin connection functional tests

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/58/ for more details.

vlorentz added inline comments.
swh/graphql/tests/functional/test_origin_connection.py
37

it seems wrong to pass GraphQL syntax as params, but ok

This revision is now accepted and ready to land.Wed, Jun 15, 1:53 PM

building query params from a dict

Build is green

Patch application report for D7989 (id=28790)

Rebasing onto 2c457bf0bc...

First, rewinding head to replay your work on top of it...
Applying: Refactor origin connection functional tests
Changes applied before test
commit b57e056a63ea5d3699ed5bccc9b4d7d4152014ab
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 15:04:14 2022 +0200

    Refactor origin connection functional tests
    
    Move the get query to a seprarate function to make adding future tests easy.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/61/ for more details.

Build is green

Patch application report for D7989 (id=28791)

Rebasing onto 2c457bf0bc...

Current branch diff-target is up to date.
Changes applied before test
commit 2026b4de3090e72f47ec67c08f4d78211d799d66
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 15:04:14 2022 +0200

    Refactor origin connection functional tests
    
    Move the get query to a seprarate function to make adding future tests easy.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/62/ for more details.

douardda added inline comments.
swh/graphql/tests/functional/test_origin_connection.py
10–33

maybe?

Build is green

Patch application report for D7989 (id=28792)

Rebasing onto 2c457bf0bc...

Current branch diff-target is up to date.
Changes applied before test
commit 66c55a2f30ced8dadb402818b5efa9be35ffcfb7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 15:04:14 2022 +0200

    Refactor origin connection functional tests
    
    Move the get query to a seprarate function to make adding future tests easy.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/63/ for more details.