Page MenuHomeSoftware Heritage

ORC: handle nullable columns/empty tables properly
ClosedPublic

Authored by seirl on Wed, Jun 1, 2:28 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

We did not check the isNullable flag and empty tables when reading ORC
files, which created some errors on the small teaser datasets.

Diff Detail

Event Timeline

Build is green

Patch application report for D7935 (id=28588)

Rebasing onto aaed82fc23...

Current branch diff-target is up to date.
Changes applied before test
commit 052ae97a4e5fa0475773844532bd831949e34ab9
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Wed Jun 1 14:21:26 2022 +0200

    ORC: handle nullable columns properly

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/198/ for more details.

seirl requested review of this revision.Wed, Jun 1, 2:34 PM
ardumont added a subscriber: ardumont.

lgtm

Side node, why aren't there tests alongside this module?

This revision is now accepted and ready to land.Wed, Jun 1, 3:52 PM

Build is green

Patch application report for D7935 (id=28783)

Rebasing onto 89975d2372...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-200-D7935.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/200/ for more details.