Build is green

Patch application report for D7892 (id=28474)

Rebasing onto 6b000fc3dd...

Current branch diff-target is up to date.

Changes applied before test

commit fb2c2d825af581d4a89271d7c74036ceb6c9186f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 25 14:49:13 2022 +0200

    Fix master build [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DDEP/job/tests/1947/console

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/845/ for more details.

looks like this bumps the django version requirement; so it would probably fail debian builds (assuming they run mypy)

looks like this bumps the django version requirement;

how so?

so it would probably fail debian builds (assuming they run mypy)

i don't think they run mypy.

In D7892#205250, @ardumont wrote:

looks like this bumps the django version requirement;

how so?

If mypy started complaining about the # type: ignore annotations, it means they stopped being useful. I assume it's because the CI uses a new version of some dependency (probably Django).

But it doesn't make them suddenly useless for older versions

looks like this bumps the django version requirement;

how so?

If mypy started complaining about the # type: ignore annotations, it means they stopped being useful. I assume it's because the CI uses a new version of some dependency (probably Django).

Yeah, I'm aligned wit this.

I assumed as much as well hence why i want to pin the world to avoid this flakyness at each upstream release...
Here, It's not mypy since this one is pinned so yeah possibly a big one like django.

But it doesn't make them suddenly useless for older versions

older versions as in debian build ok, i understand better your point now.
Still, we only run pytest in debian build so it should be fine [1]

[1] https://forge.softwareheritage.org/source/swh-deposit/browse/debian%252Funstable-swh/debian/rules

If not ok, then i don't know what another proper fix would be, any idea?
Just recall that a ci build should never be red, it should be attended by the team to fix it asap
to ease further contributions (from anyone, not only the team).

lThat's what i'm trying to do and it's annoying btw)

If not ok, then i don't know what another proper fix would be, any idea?

neither do I :(