developer-setup: Bump minimum required nodejs to 14.x
ClosedPublic
Actions

Authored by anlambert on May 19 2022, 11:14 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4259: Bump minium required nodejs version to 14.x

Commits

rDDOC80bb48c2eb3c: developer-setup: Bump minimum required nodejs to 14.x

Summary

Related to T4259

Diff Detail

Repository

rDDOC Development documentation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 19 2022, 11:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 19 2022, 11:14 AM

Build is green

Patch application report for D7861 (id=28381)

Rebasing onto c181c6dd0c...

Current branch diff-target is up to date.

Changes applied before test

commit 80bb48c2eb3c700c2389766d8a35922123f66a3c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 19 11:14:06 2022 +0200

    developer-setup: Bump minimum required nodejs to 14.x
    
    Related to T4259

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/193/ for more details.

Harbormaster completed remote builds in B29477: Diff 28381.May 19 2022, 11:28 AM

anlambert requested review of this revision.May 19 2022, 11:28 AM

vlorentz added a subscriber: vlorentz.May 19 2022, 2:48 PM

vlorentz added inline comments.

docs/developer-setup.rst
56–57	this one can remain "need to have nodejs >= 12", because swh still works with nodejs 12. +1 on the two changes below, though.

anlambert added inline comments.May 19 2022, 2:53 PM

docs/developer-setup.rst
56–57	Once D7860 landed, `swh-web` will no longer be compatible with node 12 (a couple of our dev dependencies start to drop node 12 support) so that change.