Differential D7852

templates/layout: Ensure to include piwik script in production only
ClosedPublic
Actions

Authored by anlambert on May 18 2022, 3:37 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS12661f9b3fba: templates/layout: Ensure to include piwik script in production only

Summary

The test guarding script inclusion was not precise enough.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 18 2022, 3:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 18 2022, 3:37 PM

Build has FAILED

Patch application report for D7852 (id=28359)

Rebasing onto b548d2f261...

Current branch diff-target is up to date.

Changes applied before test

commit 12661f9b3fbab9f15656dadf2a83bbabe258002d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed May 18 15:36:14 2022 +0200

    templates/layout: Ensure to include piwik script in production only

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1849/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1849/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 18 2022, 4:03 PM

Harbormaster failed remote builds in B29457: Diff 28359!

Build is green

Patch application report for D7852 (id=28359)

Rebasing onto b548d2f261...

Current branch diff-target is up to date.

Changes applied before test

commit 12661f9b3fbab9f15656dadf2a83bbabe258002d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed May 18 15:36:14 2022 +0200

    templates/layout: Ensure to include piwik script in production only

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1850/ for more details.

Harbormaster completed remote builds in B29457: Diff 28359.May 18 2022, 4:27 PM

anlambert requested review of this revision.May 18 2022, 4:27 PM

ardumont accepted this revision.May 18 2022, 5:53 PM

This revision is now accepted and ready to land.May 18 2022, 5:53 PM

Closed by commit rDWAPPS12661f9b3fba: templates/layout: Ensure to include piwik script in production only (authored by anlambert). · Explain WhyMay 19 2022, 11:04 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS12661f9b3fba: templates/layout: Ensure to include piwik script in production only.