Page MenuHomeSoftware Heritage

misc/coverage: Add count for origins listed from phabricator instances
ClosedPublic

Authored by anlambert on Thu, May 12, 4:15 PM.

Details

Summary

More origins seem to have been loaded since so let's integrate
phabricator in the coverage list.

Related to T3117

Depends on D7819

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont accepted this revision.
This revision is now accepted and ready to land.Thu, May 12, 4:36 PM

Build is green

Patch application report for D7820 (id=28241)

Could not rebase; Attempt merge onto d92988fa24...

Updating d92988fa..0294d986
Fast-forward
 swh/web/misc/coverage.py             |  41 +++++++-------
 swh/web/templates/misc/coverage.html |   4 +-
 swh/web/tests/misc/test_coverage.py  | 107 +++++++++++++++++++++++++++++++++--
 swh/web/tests/utils.py               |  16 +++++-
 4 files changed, 138 insertions(+), 30 deletions(-)
Changes applied before test
commit 0294d986d509826fab7dcc83557ca36cde376201
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 15:01:13 2022 +0200

    misc/coverage: Add count for origins listed from phabricator instances
    
    More origins seem to have been loaded since so let's integrate
    phabricator in the coverage list.
    
    Related to T3117

commit 5005f200826422d4943dcc57fee0e1403c050339
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 12 14:49:10 2022 +0200

    misc/coverage: Improve display of origin counters in production/staging
    
    If the global counter for an origin type is equal to zero, do not display
    the bootstrap card for that origin type.
    
    If a visit type counter for an origin type is equal to zero, do not
    display it in the counters table for that origin type.
    
    It enables to not take into account origins that have been listed
    but not loaded without having to hardcode that information in
    coverage widget implementation.
    
    Also use origins_enabled field from scheduler metrics instead of
    origins_known one to compute the number of loaded origins per
    visit type.
    
    Related to T3117

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1828/ for more details.