Differential D7792

api/throttling: Fix save code now throttle scope name
ClosedPublic
Actions

Authored by anlambert on May 9 2022, 3:44 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSb30dc0510f78: api/throttling: Fix save code now throttle scope name

Summary

The scope name was missing the swh_ prefix, this was missed in tests
due to an invalid rate value for POST requests (registered users can
issue 10 times more requests that anonymous users).

Diff Detail

Repository

rDWAPPS Web applications

Branch

throttling-fix-save-origin-scope-name

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29194
Build 45656: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45655: arc lint + arc unit

Event Timeline

anlambert created this revision.May 9 2022, 3:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 9 2022, 3:44 PM

Build is green

Patch application report for D7792 (id=28126)

Rebasing onto ae7c33ec99...

Current branch diff-target is up to date.

Changes applied before test

commit b30dc0510f78d8fcf514d7e7d43050e1c1084da2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon May 9 15:43:27 2022 +0200

    api/throttling: Fix save code now throttle scope name
    
    The scope name was missing the swh_ prefix, this was missed in tests
    due to an invalid rate value for POST requests (registered users can
    issue 10 times more requests that anonymous users).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1805/ for more details.

Harbormaster completed remote builds in B29194: Diff 28126.May 9 2022, 4:08 PM

anlambert requested review of this revision.May 9 2022, 4:08 PM

vlorentz accepted this revision.May 9 2022, 4:15 PM

This revision is now accepted and ready to land.May 9 2022, 4:15 PM

Closed by commit rDWAPPSb30dc0510f78: api/throttling: Fix save code now throttle scope name (authored by anlambert). · Explain WhyMay 9 2022, 4:28 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSb30dc0510f78: api/throttling: Fix save code now throttle scope name.