Page MenuHomeSoftware Heritage

Use the in-mem storage.
ClosedPublic

Authored by vlorentz on Wed, Dec 5, 1:41 PM.

Diff Detail

Repository
rDLDDIR Directory Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Dec 5, 1:41 PM
ardumont accepted this revision.Wed, Dec 5, 2:01 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/dir/tests/test_loader.py
55

That's not needed.

This revision is now accepted and ready to land.Wed, Dec 5, 2:01 PM
vlorentz marked an inline comment as done.Wed, Dec 5, 2:11 PM
vlorentz added inline comments.
swh/loader/dir/tests/test_loader.py
55

It is. BaseDirLoaderTest.setUp extracts a tarball.

This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Wed, Dec 5, 4:39 PM
swh/loader/dir/tests/test_loader.py
55

In my mind, if you don't define it, it's called anyway, isn't it?

anlambert added inline comments.
swh/loader/dir/tests/test_loader.py
55

Yes it is ;-)

ardumont added inline comments.Wed, Dec 5, 4:46 PM
swh/loader/dir/tests/test_loader.py
55

so it's not needed?!

;)

anlambert added inline comments.Wed, Dec 5, 4:47 PM
swh/loader/dir/tests/test_loader.py
55

Absolutely not needed!

vlorentz marked an inline comment as done.Wed, Dec 5, 5:29 PM
vlorentz added inline comments.
swh/loader/dir/tests/test_loader.py
55

But setUp needs to be defined, because it does other stuff (look just below this comment, that's still the setUp code)

anlambert added inline comments.Wed, Dec 5, 5:32 PM
swh/loader/dir/tests/test_loader.py
55

Sorry, got mistaken by the comment boxes from Phabricator that was hiding the rest of the code and thought the method was only one line long.
So the call to the parent method is of course needed in that case.

ardumont added inline comments.Wed, Dec 5, 5:38 PM
swh/loader/dir/tests/test_loader.py
55

Right, same here!