Differential D7759

docs: Open external link in new browser tab
ClosedPublic
Actions

Authored by anlambert on May 6 2022, 3:43 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDOCe3b920316584: docs: Open external link in new browser tab

Summary

It is a common practice to open an external link in a new browser
tab so process external links with javascript when a documentation
page got loaded to enforce such behavior.

Diff Detail

Repository

rDDOC Development documentation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 6 2022, 3:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2022, 3:43 PM

Build is green

Patch application report for D7759 (id=28072)

Rebasing onto 8eb04fcd8a...

Current branch diff-target is up to date.

Changes applied before test

commit e3b9203165847e3239ce1f3f27873834468c5772
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 15:40:37 2022 +0200

    docs: Open external link in new browser tab
    
    It is a common practice to open an external link in a new browser
    tab so process external links with javascript when a documentation
    page got loaded to enforce such behavior.

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/183/ for more details.

Harbormaster completed remote builds in B29143: Diff 28072.May 6 2022, 3:55 PM

anlambert requested review of this revision.May 6 2022, 3:55 PM

ardumont accepted this revision.May 9 2022, 9:53 AM

This revision is now accepted and ready to land.May 9 2022, 9:53 AM

Closed by commit rDDOCe3b920316584: docs: Open external link in new browser tab (authored by anlambert). · Explain WhyMay 9 2022, 10:41 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDDOCe3b920316584: docs: Open external link in new browser tab.