Fix T4114
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- T4114: Add logging by default to swh-graph compression
- Commits
- rDGRPH464fded2cd8b: Add logging to compression pipeline
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7758 (id=28070)
Rebasing onto 8b34fb1d4f...
Current branch diff-target is up to date.
Changes applied before test
commit 1a3effc49109ba3f3510b9a4d5d224deee142389
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri May 6 15:18:03 2022 +0200
Add logging to compression pipeline
Fix T4114See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/183/ for more details.
| swh/graph/webgraph.py | ||
|---|---|---|
| 269 | I would call that f"steps.{step.name}" to make it clear that this is a separate logger hierarchy for steps. | |
| 278 | That format doesn't have %(asctime)s, so I'd use a more specific one. Probably something along the lines of "%(asctime)s %(levelname)s(%(func)s) %(message)s" (which drops the redundant %(name)s too, as you have one file per step). | |
| 302–313 | You should add step_logger.removeHandler(step_handler) and step_handler.close() when this function ends to avoid keeping the per-step logfiles open until the logging module tears down. | |
Comment Actions
Build is green
Patch application report for D7758 (id=28073)
Rebasing onto 8b34fb1d4f...
Current branch diff-target is up to date.
Changes applied before test
commit 464fded2cd8bbd2e9657fd7b4b783fdae2c31ffc
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri May 6 15:18:03 2022 +0200
Add logging to compression pipeline
Fix T4114See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/184/ for more details.