Page MenuHomeSoftware Heritage
Differential D7757

templates/content-display: Check content rendering for mime type first
ClosedPublic
Actions

Authored by anlambert on May 6 2022, 2:35 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPSae7c33ec99ef: templates/content-display: Check content rendering for mime type first
Summary

The webapp can render some special content types (images, pdf) based on the
mimetype of the currently browsed content object.

However the checks of these mime types were done after the check for source
code rendering which could lead to errors client side.

Fixes SWH-WEBAPP-3T3

Diff Detail

Repository
rDWAPPS Web applications
Branch
image-pdf-rendering-fixes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29165
Build 45599: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 45598: arc lint + arc unit

Event Timeline

anlambert created this revision.May 6 2022, 2:35 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2022, 2:35 PM
anlambert updated this revision to Diff 28066.May 6 2022, 2:44 PM

Update years in license headers

swh-public-ci added a comment.May 6 2022, 2:57 PM

Build is green

Patch application report for D7757 (id=28065)

Rebasing onto 54e679c461...

Current branch diff-target is up to date.
Changes applied before test
commit 6d8239214f58e9bd687f18ef1a4c7a5333123ee3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 14:31:59 2022 +0200

    templates/content-display: Check content rendering for mime type first
    
    The webapp can render some special content types (images, pdf) based on the
    mimetype of the currently browsed content object.
    
    However the checks of these mime types were done after the check for source
    code rendering which could lead to errors client side.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1792/ for more details.

Harbormaster completed remote builds in B29136: Diff 28065.May 6 2022, 2:57 PM
swh-public-ci added a comment.May 6 2022, 3:06 PM

Build is green

Patch application report for D7757 (id=28066)

Rebasing onto 54e679c461...

Current branch diff-target is up to date.
Changes applied before test
commit 5e679a19ccd9ea45e4aa51fd61374f0464f77d8c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 14:31:59 2022 +0200

    templates/content-display: Check content rendering for mime type first
    
    The webapp can render some special content types (images, pdf) based on the
    mimetype of the currently browsed content object.
    
    However the checks of these mime types were done after the check for source
    code rendering which could lead to errors client side.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1793/ for more details.

Harbormaster completed remote builds in B29137: Diff 28066.May 6 2022, 3:06 PM
anlambert requested review of this revision.May 6 2022, 3:06 PM
anlambert updated this revision to Diff 28071.May 6 2022, 3:30 PM

Rebase

swh-public-ci added a comment.May 6 2022, 3:51 PM

Build is green

Patch application report for D7757 (id=28071)

Rebasing onto e6a8303eef...

Current branch diff-target is up to date.
Changes applied before test
commit 47b142d181c0c5e3b0447a27c368f100b63a6241
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 14:31:59 2022 +0200

    templates/content-display: Check content rendering for mime type first
    
    The webapp can render some special content types (images, pdf) based on the
    mimetype of the currently browsed content object.
    
    However the checks of these mime types were done after the check for source
    code rendering which could lead to errors client side.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1795/ for more details.

Harbormaster completed remote builds in B29142: Diff 28071.May 6 2022, 3:51 PM
ardumont accepted this revision.May 9 2022, 9:55 AM
This revision is now accepted and ready to land.May 9 2022, 9:55 AM
anlambert updated this revision to Diff 28095.May 9 2022, 10:49 AM

Rebase

swh-public-ci added a comment.May 9 2022, 11:12 AM

Build is green

Patch application report for D7757 (id=28095)

Rebasing onto 96cc635cab...

Current branch diff-target is up to date.
Changes applied before test
commit ae7c33ec99efed523a80ed3b50ee17778cb1dc2a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 14:31:59 2022 +0200

    templates/content-display: Check content rendering for mime type first
    
    The webapp can render some special content types (images, pdf) based on the
    mimetype of the currently browsed content object.
    
    However the checks of these mime types were done after the check for source
    code rendering which could lead to errors client side.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1803/ for more details.

Harbormaster completed remote builds in B29165: Diff 28095.May 9 2022, 11:12 AM
Closed by commit rDWAPPSae7c33ec99ef: templates/content-display: Check content rendering for mime type first (authored by anlambert). · Explain WhyMay 9 2022, 2:56 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSae7c33ec99ef: templates/content-display: Check content rendering for mime type first.

Revision Contents
Changeset List

PathSize
cypress/
integration/
6 lines
swh/
web/
templates/
includes/
16 lines

Diff 28095

View Options

cypress/integration/content-rendering.spec.js

Loading...
View Options

swh/web/templates/includes/content-display.html

Loading...
About · Developer information · Legal