Page MenuHomeSoftware Heritage
Differential D7745

Create a new statsd instance to manage namespace and constant tags.
ClosedPublic
Actions

Authored by vlorentz on May 5 2022, 2:23 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDLDBASEa3a2b11473d2: Create a new statsd instance to manage namespace and constant tags.
Summary

Implements D7726#201820

Depends on D7727.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 5 2022, 2:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 5 2022, 2:23 PM
vlorentz edited the summary of this revision. (Show Details)May 5 2022, 2:23 PM
vlorentz added a parent revision: D7727: loader.core: Add statsd metrics on collected metadata.
swh-public-ci added a comment.May 5 2022, 2:27 PM

Build is green

Patch application report for D7745 (id=28008)

Could not rebase; Attempt merge onto a097a946c2...

Merge made by the 'recursive' strategy.
 swh/loader/core/loader.py               |  86 +++++++++++++++++++++---
 swh/loader/core/metadata_fetchers.py    |   1 +
 swh/loader/core/tests/test_loader.py    | 114 ++++++++++++++++++++++++++++++--
 swh/loader/package/tests/test_loader.py |   6 +-
 4 files changed, 187 insertions(+), 20 deletions(-)
Changes applied before test
commit 26bcd85a42a4594fffb381774950db3c81e1b903
Merge: a097a94 686b4c0
Author: Jenkins user <jenkins@localhost>
Date:   Thu May 5 12:23:48 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 686b4c043efb8d2f49a7abf87b5b7f8dd950691e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 5 14:22:37 2022 +0200

    Create a new statsd instance to manage namespace and constant tags.

commit c0b92637fabb3ec3db72762a4ec153c5825e6099
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:21:36 2022 +0200

    loader.core: Add statsd metrics on collected metadata

commit da8793f99d60a148cc39721b8697dfc6a5d81cea
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:20:52 2022 +0200

    loader.core: Add statsd timing metrics

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/780/ for more details.

Harbormaster completed remote builds in B29087: Diff 28008.May 5 2022, 2:27 PM
vlorentz requested review of this revision.May 5 2022, 2:27 PM
olasd accepted this revision.May 5 2022, 5:45 PM
olasd added a subscriber: olasd.

LGTM, thanks.

Maybe the localized statsd methods could use a docstring and type annotations.

swh/loader/core/loader.py
497–498
This revision is now accepted and ready to land.May 5 2022, 5:45 PM
vlorentz updated this revision to Diff 28036.May 6 2022, 10:18 AM

Add docstrings, types, and remove unnecessary context-manager wrapping.

vlorentz marked an inline comment as done.May 6 2022, 10:18 AM
swh-public-ci added a comment.May 6 2022, 10:21 AM

Build is green

Patch application report for D7745 (id=28036)

Could not rebase; Attempt merge onto a097a946c2...

Merge made by the 'recursive' strategy.
 swh/loader/core/loader.py               |  98 ++++++++++++++++++++++++---
 swh/loader/core/metadata_fetchers.py    |   1 +
 swh/loader/core/tests/test_loader.py    | 114 ++++++++++++++++++++++++++++++--
 swh/loader/package/tests/test_loader.py |   6 +-
 4 files changed, 198 insertions(+), 21 deletions(-)
Changes applied before test
commit 4684f49e3383892840c2b2a2cf78112da9e15c77
Merge: a097a94 d30857f
Author: Jenkins user <jenkins@localhost>
Date:   Fri May 6 08:18:53 2022 +0000

    Merge branch 'diff-target' into HEAD

commit d30857ffdefd62e79d6cbdade85d4fffd16f2834
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 5 14:22:37 2022 +0200

    Create a new statsd instance to manage namespace and constant tags.

commit c0b92637fabb3ec3db72762a4ec153c5825e6099
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:21:36 2022 +0200

    loader.core: Add statsd metrics on collected metadata

commit da8793f99d60a148cc39721b8697dfc6a5d81cea
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:20:52 2022 +0200

    loader.core: Add statsd timing metrics

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/781/ for more details.

Harbormaster completed remote builds in B29107: Diff 28036.May 6 2022, 10:21 AM
vlorentz updated this revision to Diff 28039.May 6 2022, 10:27 AM

rebase

swh-public-ci added a comment.May 6 2022, 10:30 AM

Build is green

Patch application report for D7745 (id=28039)

Could not rebase; Attempt merge onto a097a946c2...

Updating a097a94..a3a2b11
Fast-forward
 swh/loader/core/loader.py               |  98 ++++++++++++++++++++++++---
 swh/loader/core/metadata_fetchers.py    |   1 +
 swh/loader/core/tests/test_loader.py    | 114 ++++++++++++++++++++++++++++++--
 swh/loader/package/tests/test_loader.py |   6 +-
 4 files changed, 198 insertions(+), 21 deletions(-)
Changes applied before test
commit a3a2b11473d200faecafcdb37d42f7362ef8cfd9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 5 14:22:37 2022 +0200

    Create a new statsd instance to manage namespace and constant tags.

commit c4b1119763eff3e8316cad701a3203004dcba26a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:21:36 2022 +0200

    loader.core: Add statsd metrics on collected metadata

commit 6ca6d5cf9cefb595ee8f1ad3fcf5decf4008aafb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 15:20:52 2022 +0200

    loader.core: Add statsd timing metrics

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/784/ for more details.

Harbormaster completed remote builds in B29110: Diff 28039.May 6 2022, 10:30 AM
Closed by commit rDLDBASEa3a2b11473d2: Create a new statsd instance to manage namespace and constant tags. (authored by vlorentz). · Explain WhyMay 6 2022, 10:35 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDBASEa3a2b11473d2: Create a new statsd instance to manage namespace and constant tags..

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
56 lines
tests/
73 lines
package/
tests/
6 lines

Diff 28042

View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
View Options

swh/loader/package/tests/test_loader.py

Loading...
About · Developer information · Legal