Differential D7730

loader: Handle origin URL redirection in SvnLoaderFromRemoteDump
ClosedPublic
Actions

Authored by anlambert on May 3 2022, 2:15 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3874: staging: Analyze result of the maven listing and ingestion

Commits

rDLDSVN377aa3234570: loader: Handle origin URL redirection in SvnLoaderFromRemoteDump

Summary

svnrdump does not handle repository URL redirection while svn client does.

So ensure to use redirected subversion origin URL to dump a repository.

Issue found from an output of the maven lister that can list subversion
origins.

anlambert@carnavalet:/tmp$ svnrdump dump http://anonsvn.jboss.org/repos/jbossas/projects/ejb3/tags/jboss-ejb3-1.1.9
svnrdump: E170011: Repository moved permanently to 'https://anonsvn.jboss.org/repos/jbossas/projects/ejb3/tags/jboss-ejb3-1.1.9'

anlambert@carnavalet:/tmp$ svn info http://anonsvn.jboss.org/repos/jbossas/projects/ejb3/tags/jboss-ejb3-1.1.9
Redirecting to URL 'https://anonsvn.jboss.org/repos/jbossas/projects/ejb3/tags/jboss-ejb3-1.1.9':
Path: jboss-ejb3-1.1.9
URL: https://anonsvn.jboss.org/repos/jbossas/projects/ejb3/tags/jboss-ejb3-1.1.9
Relative URL: ^/projects/ejb3/tags/jboss-ejb3-1.1.9
Repository Root: https://anonsvn.jboss.org/repos/jbossas
Repository UUID: 84be2c1e-ba19-0410-b317-a758671a6fc1
Revision: 114873
Node Kind: directory
Last Changed Author: jaikiran
Last Changed Rev: 91090
Last Changed Date: 2009-07-10 17:12:19 +0200 (ven., 10 juil. 2009)

Related to T3874

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

remmote-dump-loader-handle-redirection

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29024
Build 45374: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45373: arc lint + arc unit

Event Timeline

anlambert created this revision.May 3 2022, 2:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 3 2022, 2:15 PM

Build is green

Patch application report for D7730 (id=27951)

Rebasing onto 1633257f11...

Current branch diff-target is up to date.

Changes applied before test

commit 377aa323457014f24af5ee9b75de5249a35d7f8e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 3 14:10:05 2022 +0200

    loader: Handle origin URL redirection in SvnLoaderFromRemoteDump
    
    svnrdump does not handle repository URL redirection while svn client does.
    
    So ensure to use redirected subversion origin URL to dump a repository.
    
    Related to T3874

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/327/ for more details.

Harbormaster completed remote builds in B29024: Diff 27951.May 3 2022, 2:17 PM

anlambert requested review of this revision.May 3 2022, 2:17 PM

vlorentz accepted this revision.May 3 2022, 4:32 PM

This revision is now accepted and ready to land.May 3 2022, 4:32 PM

Closed by commit rDLDSVN377aa3234570: loader: Handle origin URL redirection in SvnLoaderFromRemoteDump (authored by anlambert). · Explain WhyMay 3 2022, 5:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN377aa3234570: loader: Handle origin URL redirection in SvnLoaderFromRemoteDump.