Page MenuHomeSoftware Heritage

Rename equality test methods.
ClosedPublic

Authored by vlorentz on Dec 4 2018, 4:28 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
rename-equality-test-methods
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2832
Build 3569: tox-on-jenkinsJenkins
Build 3568: arc lint + arc unit

Event Timeline

  • Fix name.
  • Add aliases for old method names, that show a warning.
  • Rename file (I'll use the same file name in other tests).
anlambert added a subscriber: anlambert.

Apart some verb that should be in imperative form in some docstrings, looks good to me

swh/loader/core/tests/__init__.py
43

s/Checks/Check/

56

s/Checks/Check/

78

s/Checks/Check/

146

s/Checks/Check/

This revision is now accepted and ready to land.Dec 5 2018, 11:25 AM
  • Remove compatibility aliases, we're completely breaking them anyway.

Landed in 39496027b27f31167de2fdcb107ef5c7efbd4901.