Differential D7702

tasks: Simplify implementation and add tests for listed origins
ClosedPublic
Actions

Authored by anlambert on Apr 27 2022, 4:10 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4187: Pass forge type to loaders

Commits

rDLDCVS4fc652339e92: tasks: Simplify implementation and add tests for listed origins

Summary

Recent changes in swh-scheduler add new parameters to the celery tasks
produced from swh.scheduler.model.ListedOrigin instances.

So ensure to handle any new parameters by not hardcoding the expected
ones in task signatures.

Remove unsafe use of unnamed task parameters.

Add new tests checking task parameters produced from ListedOrigin
instances do no raise error when attempting to create a cvs loader.

Related to T4187

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28895
Build 45166: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45165: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 27 2022, 4:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 27 2022, 4:10 PM

thanks!

This revision is now accepted and ready to land.Apr 27 2022, 4:10 PM

Build is green

Patch application report for D7702 (id=27833)

Rebasing onto 3a99ed0df9...

Current branch diff-target is up to date.

Changes applied before test

commit 4fc652339e92db5691bb3c96a6b0581e7b278da1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 16:09:53 2022 +0200

    tasks: Simplify implementation and add tests for listed origins
    
    Recent changes in swh-scheduler add new parameters to the celery tasks
    produced from swh.scheduler.model.ListedOrigin instances.
    
    So ensure to handle any new parameters by not hardcoding the expected
    ones in task signatures.
    
    Remove unsafe use of unnamed task parameters.
    
    Add new tests checking task parameters produced from ListedOrigin
    instances do no raise error when attempting to create a cvs loader.
    
    Related to T4187

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/107/ for more details.

Harbormaster completed remote builds in B28895: Diff 27833.Apr 27 2022, 4:12 PM

Closed by commit rDLDCVS4fc652339e92: tasks: Simplify implementation and add tests for listed origins (authored by anlambert). · Explain WhyApr 27 2022, 4:15 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDCVS4fc652339e92: tasks: Simplify implementation and add tests for listed origins.