Differential D7699

tasks: Simplify implementation and add tests for listed origins
ClosedPublic
Actions

Authored by anlambert on Apr 27 2022, 3:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4187: Pass forge type to loaders

Commits

rDLDHG3a551fa90d3a: tasks: Simplify implementation and add tests for listed origins

Summary

Recent changes in swh-scheduler add new parameters to the celery tasks
produced from swh.scheduler.model.ListedOrigin instances.

So ensure to handle any new parameters by not hardcoding the expected
ones in task signatures.

Remove unsafe use of unnamed task parameters.

Add new tests checking task parameters produced from ListedOrigin
instances do no raise error when attempting to create a hg loader.

Related to T4187

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 27 2022, 3:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 27 2022, 3:24 PM

Build is green

Patch application report for D7699 (id=27829)

Rebasing onto 18025f1c3c...

Current branch diff-target is up to date.

Changes applied before test

commit 3a551fa90d3a5570f9898b6fde4e61b671d2fc0e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 15:21:47 2022 +0200

    tasks: Simplify implementation and add tests for listed origins
    
    Recent changes in swh-scheduler add new parameters to the celery tasks
    produced from swh.scheduler.model.ListedOrigin instances.
    
    So ensure to handle any new parameters by not hardcoding the expected
    ones in task signatures.
    
    Remove unsafe use of unnamed task parameters.
    
    Add new tests checking task parameters produced from ListedOrigin
    instances do no raise error when attempting to create a hg loader.
    
    Related to T4187

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/339/ for more details.

Harbormaster completed remote builds in B28890: Diff 27829.Apr 27 2022, 3:26 PM

anlambert requested review of this revision.Apr 27 2022, 3:26 PM

ardumont accepted this revision.Apr 27 2022, 4:03 PM

This revision is now accepted and ready to land.Apr 27 2022, 4:03 PM

Closed by commit rDLDHG3a551fa90d3a: tasks: Simplify implementation and add tests for listed origins (authored by anlambert). · Explain WhyApr 27 2022, 4:16 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDHG3a551fa90d3a: tasks: Simplify implementation and add tests for listed origins.