Replace 'base_url' argument with 'self.parent_origins' attribute
ClosedPublic
Actions

Authored by vlorentz on Apr 27 2022, 2:05 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3273: Use "fork" relationships to speed-up initial load of large repositories

Commits

rDLDG4ede7b351783: Replace 'base_url' argument with 'self.parent_origins' attribute

Summary

self.parent_origins is set dynamically by the core loader at the
beginning of the load (before calling prepare()), using the right
metadata loaders.

Test Plan

CI will fail because D7691 is not released yet

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 27 2022, 2:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 27 2022, 2:05 PM

vlorentz added a parent revision: D7691: Store the result of MetadataFetcher.get_parent_origins.Apr 27 2022, 2:05 PM

Build has FAILED

Patch application report for D7695 (id=27823)

Rebasing onto 05242cd461...

Current branch diff-target is up to date.

Changes applied before test

commit 4ede7b351783e87ed3a738f063bbad4a177511d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 27 14:02:05 2022 +0200

    Replace 'base_url' argument with 'self.parent_origins' attribute
    
    self.parent_origins is set dynamically by the core loader at the
    beginning of the load (before calling `prepare()`), using the right
    metadata loaders.

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/195/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/195/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 27 2022, 2:05 PM

Harbormaster failed remote builds in B28884: Diff 27823!

vlorentz requested review of this revision.Apr 27 2022, 2:05 PM

vlorentz added a task: T3273: Use "fork" relationships to speed-up initial load of large repositories.Apr 27 2022, 2:07 PM

Very nice, thanks!

This revision is now accepted and ready to land.Apr 27 2022, 2:07 PM

Build has FAILED

Patch application report for D7695 (id=27823)

Rebasing onto 05242cd461...

Current branch diff-target is up to date.

Changes applied before test

commit 4ede7b351783e87ed3a738f063bbad4a177511d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 27 14:02:05 2022 +0200

    Replace 'base_url' argument with 'self.parent_origins' attribute
    
    self.parent_origins is set dynamically by the core loader at the
    beginning of the load (before calling `prepare()`), using the right
    metadata loaders.

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/196/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/196/console

Build is green

Patch application report for D7695 (id=27823)

Rebasing onto 05242cd461...

Current branch diff-target is up to date.

Changes applied before test

commit 4ede7b351783e87ed3a738f063bbad4a177511d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 27 14:02:05 2022 +0200

    Replace 'base_url' argument with 'self.parent_origins' attribute
    
    self.parent_origins is set dynamically by the core loader at the
    beginning of the load (before calling `prepare()`), using the right
    metadata loaders.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/197/ for more details.

Harbormaster completed remote builds in B28884: Diff 27823.Apr 27 2022, 4:36 PM

Closed by commit rDLDG4ede7b351783: Replace 'base_url' argument with 'self.parent_origins' attribute (authored by vlorentz). · Explain WhyApr 27 2022, 4:36 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG4ede7b351783: Replace 'base_url' argument with 'self.parent_origins' attribute.