Page MenuHomeSoftware Heritage

Remove mypy version pin, and fix support of mypy 0.942
AbandonedPublic

Authored by vlorentz on Apr 25 2022, 1:37 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
origin-metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28718
Build 44876: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44875: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D7643 (id=27661)

Could not rebase; Attempt merge onto c4c0a9b5aa...

Merge made by the 'recursive' strategy.
 swh/loader/core/loader.py            | 92 ++++++++++++++++++++++++++++++++++--
 swh/loader/core/metadata_fetchers.py | 47 ++++++++++++++++++
 swh/loader/core/tests/test_loader.py | 57 ++++++++++++++++++++++
 swh/loader/package/loader.py         | 38 ++-------------
 tox.ini                              |  2 +-
 5 files changed, 199 insertions(+), 37 deletions(-)
 create mode 100644 swh/loader/core/metadata_fetchers.py
Changes applied before test
commit 55fee88684ef38aad131db2668f3040628a9e99c
Merge: c4c0a9b 16046ae
Author: Jenkins user <jenkins@localhost>
Date:   Mon Apr 25 11:37:34 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 16046ae65ca9f7f467adb59eeb9d1df4b5bc7a8d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 13:37:14 2022 +0200

    Remove mypy version pin, and fix support of mypy 0.942

commit cd1c10ae5e60cd270e8456822feae809cf2e26bb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 14:59:07 2022 +0200

    BaseLoader: Add hook to call metadata fetchers before loading an origin
    
    This uses setuptools entrypoints to allow metadata fetchers to
    make themselves discoverable without explicitly depending on them.
    
    This commit also lifts the generic metadata loading from the base
    PackageLoader to BaseLoader

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/735/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/735/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 25 2022, 1:38 PM
Harbormaster failed remote builds in B28718: Diff 27661!

Build is green

Patch application report for D7643 (id=27661)

Could not rebase; Attempt merge onto c4c0a9b5aa...

Merge made by the 'recursive' strategy.
 swh/loader/core/loader.py            | 92 ++++++++++++++++++++++++++++++++++--
 swh/loader/core/metadata_fetchers.py | 47 ++++++++++++++++++
 swh/loader/core/tests/test_loader.py | 57 ++++++++++++++++++++++
 swh/loader/package/loader.py         | 38 ++-------------
 tox.ini                              |  2 +-
 5 files changed, 199 insertions(+), 37 deletions(-)
 create mode 100644 swh/loader/core/metadata_fetchers.py
Changes applied before test
commit 6ca899044df328ca53801beb0e3cc9e61202fa21
Merge: c4c0a9b 16046ae
Author: Jenkins user <jenkins@localhost>
Date:   Mon Apr 25 16:31:54 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 16046ae65ca9f7f467adb59eeb9d1df4b5bc7a8d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Apr 25 13:37:14 2022 +0200

    Remove mypy version pin, and fix support of mypy 0.942

commit cd1c10ae5e60cd270e8456822feae809cf2e26bb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 14:59:07 2022 +0200

    BaseLoader: Add hook to call metadata fetchers before loading an origin
    
    This uses setuptools entrypoints to allow metadata fetchers to
    make themselves discoverable without explicitly depending on them.
    
    This commit also lifts the generic metadata loading from the base
    PackageLoader to BaseLoader

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/738/ for more details.

ardumont added inline comments.
tox.ini
37

Please, keep the pin versioning.
I added it because i was fed up unbreaking the ci [1] when a new upstream release "break" everything [builds go red in cascading effect).

[1] It happens to me at least thrice and each time, it took me like 2 days to make everything go green again.
I don't want to have to deal with it again.

Also, if you upgrade mypy everywhere, there is a mention in the docs that needs updating as well [1].

[1] https://docs.softwareheritage.org/devel/developer-setup.html#checkout-the-source-code

This revision now requires changes to proceed.Apr 26 2022, 9:48 AM