Page MenuHomeSoftware Heritage

Make create_origin_task_dict a standalone function
ClosedPublic

Authored by vlorentz on Apr 21 2022, 11:23 AM.

Details

Summary

It feels off as an object method; and I am going to make it use joins
in a future commit, so it makes more sense this way.

Depends on D7617.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7618 (id=27591)

Could not rebase; Attempt merge onto a76bb02f0e...

Auto-merging swh/scheduler/celery_backend/recurrent_visits.py
Merge made by the 'recursive' strategy.
 swh/scheduler/celery_backend/recurrent_visits.py |   5 +-
 swh/scheduler/cli/origin.py                      |   5 +-
 swh/scheduler/simulator/__init__.py              |   3 +-
 swh/scheduler/tests/test_model.py                |  33 ----
 swh/scheduler/tests/test_utils.py                | 183 +++++++++++++----------
 swh/scheduler/utils.py                           |  15 +-
 6 files changed, 130 insertions(+), 114 deletions(-)
Changes applied before test
commit ebdcf14566a1b34d44a52ebda11dc2cb8105223b
Merge: a76bb02 600276c
Author: Jenkins user <jenkins@localhost>
Date:   Thu Apr 21 09:24:08 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 600276ce87b7282d8101a2c59a5a3128415220f3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:22:48 2022 +0200

    Make create_origin_task_dict a standalone function
    
    It feels off as a method method; and I am going to make it use joins
    in a future commit, so it makes more sense this way.

commit 0df5e61c4a153e2bfbf1e4a261a061999617f16c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:21:05 2022 +0200

    test_utils.py: Convert to pytest-style tests

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/530/ for more details.

Build is green

Patch application report for D7618 (id=27592)

Could not rebase; Attempt merge onto a76bb02f0e...

Auto-merging swh/scheduler/celery_backend/recurrent_visits.py
Merge made by the 'recursive' strategy.
 swh/scheduler/celery_backend/recurrent_visits.py |   5 +-
 swh/scheduler/cli/origin.py                      |   5 +-
 swh/scheduler/model.py                           |   9 --
 swh/scheduler/simulator/__init__.py              |   3 +-
 swh/scheduler/tests/test_model.py                |  33 ----
 swh/scheduler/tests/test_utils.py                | 183 +++++++++++++----------
 swh/scheduler/utils.py                           |  15 +-
 7 files changed, 130 insertions(+), 123 deletions(-)
Changes applied before test
commit fc9d22afb38abbda044239ecf9ca6a36075a334a
Merge: a76bb02 a89f124
Author: Jenkins user <jenkins@localhost>
Date:   Thu Apr 21 09:25:12 2022 +0000

    Merge branch 'diff-target' into HEAD

commit a89f124ac25485ca92946bbee6bf56398e25023f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:22:48 2022 +0200

    Make create_origin_task_dict a standalone function
    
    It feels off as a method method; and I am going to make it use joins
    in a future commit, so it makes more sense this way.

commit 0df5e61c4a153e2bfbf1e4a261a061999617f16c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:21:05 2022 +0200

    test_utils.py: Convert to pytest-style tests

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/531/ for more details.

Build is green

Patch application report for D7618 (id=27601)

Rebasing onto 5e9ee60d7f...

Current branch diff-target is up to date.
Changes applied before test
commit 07bc422f2ca467f8cfc780b9e5dbd0976efb677a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:22:48 2022 +0200

    Make create_origin_task_dict a standalone function
    
    It feels off as a method method; and I am going to make it use joins
    in a future commit, so it makes more sense this way.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/533/ for more details.

ardumont added a subscriber: ardumont.

lgtm

Your comment (description) seems a bit off though.
method method is probably object method?

This revision now requires changes to proceed.Apr 21 2022, 2:25 PM

(oops, wrong selection)

This revision is now accepted and ready to land.Apr 21 2022, 2:25 PM
This revision was landed with ongoing or failed builds.Apr 21 2022, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7618 (id=27615)

Rebasing onto 9483493ff5...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-535-D7618.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/535/ for more details.