Page MenuHomeSoftware Heritage

svn: Update for swh.loader.core 3.0.0 and remove initialization boilerplate
ClosedPublic

Authored by vlorentz on Apr 21 2022, 10:11 AM.

Details

Test Plan

will fail because it depends on D7610 being released

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz retitled this revision from Update for swh.loader.core 3.0.0 and remove initialization boilerplate to svn: Update for swh.loader.core 3.0.0 and remove initialization boilerplate.Apr 21 2022, 10:11 AM

Build has FAILED

Patch application report for D7615 (id=27580)

Rebasing onto 2f1d9c23f7...

Current branch diff-target is up to date.
Changes applied before test
commit 821a51307ae9c788aed35fa89c2a380b1132c6fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 10:10:47 2022 +0200

    Update for swh.loader.core 3.0.0 and remove initialization boilerplate

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/314/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/314/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 21 2022, 10:11 AM
Harbormaster failed remote builds in B28607: Diff 27580!
ardumont added a subscriber: ardumont.

1 comment inline.

swh/loader/svn/loader.py
94–96

it's still as readable that way.

This revision is now accepted and ready to land.Apr 21 2022, 10:34 AM

Build is green

Patch application report for D7615 (id=27580)

Rebasing onto 2f1d9c23f7...

Current branch diff-target is up to date.
Changes applied before test
commit 821a51307ae9c788aed35fa89c2a380b1132c6fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 10:10:47 2022 +0200

    Update for swh.loader.core 3.0.0 and remove initialization boilerplate

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/315/ for more details.

swh/loader/svn/loader.py
94–96

I think it is clearer this way, to have comments associated to each of the two variables