Page MenuHomeSoftware Heritage

Parse Maven licenses.
ClosedPublic

Authored by vlorentz on Nov 30 2018, 4:58 PM.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
maven-license
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2770
Build 3478: tox-on-jenkinsJenkins
Build 3477: arc lint + arc unit

Event Timeline

zack requested changes to this revision.Dec 1 2018, 3:51 PM
zack added a subscriber: zack.
zack added inline comments.
swh/indexer/metadata_dictionary.py
283

What happens when multiple <license> elements are present?

It would be nice to have:

  • a dedicated test case for that, and
  • a description of the general semantics of how that is handled in the docstirng of this method
This revision now requires changes to proceed.Dec 1 2018, 3:51 PM
  • Add doc and tests for the Maven parser.
vlorentz added inline comments.
swh/indexer/metadata_dictionary.py
283

This method always returns a list, so there's nothing interesting here. However, JSON-LD compaction happens later, so I added tests for that.

zack added inline comments.
swh/indexer/metadata_dictionary.py
283

The fact that I wanted documented (in the docstring, type annotation, whatever) was precisely that it always returns a list :-)

This revision is now accepted and ready to land.Dec 3 2018, 10:57 AM
vlorentz added inline comments.
swh/indexer/metadata_dictionary.py
283

True. I added a task to remember to document all these methods further: T1403

This revision was automatically updated to reflect the committed changes.