Differential D7564

api/server: Drop dead code
ClosedPublic
Actions

Authored by ardumont on Apr 13 2022, 2:49 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDVAUc8b9c6fdc4a2: api/server: Drop dead code

Summary

It was a class parameter from the swh.core.api.asynchronous.RPCServerApp which got
removed some time ago.

This is not defined in the swh.core.api.RPCServerApp.

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28429
Build 44445: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44444: arc lint + arc unit

Event Timeline

ardumont created this revision.Apr 13 2022, 2:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 13 2022, 2:49 PM

Build is green

Patch application report for D7564 (id=27414)

Rebasing onto d2d7b5cf1e...

Current branch diff-target is up to date.

Changes applied before test

commit c8b9c6fdc4a26eb6d3b39509756d919a5db4c89b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Apr 13 14:48:34 2022 +0200

    api/server: Drop dead code
    
    It was a class parameter from the swh.core.api.asynchronous.RPCServerApp which got
    removed some time ago.
    
    This is not defined in the swh.core.api.RPCServerApp.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/227/ for more details.

Harbormaster completed remote builds in B28429: Diff 27414.Apr 13 2022, 2:52 PM

ardumont requested review of this revision.Apr 13 2022, 2:52 PM

vlorentz accepted this revision.Apr 13 2022, 4:04 PM

This revision is now accepted and ready to land.Apr 13 2022, 4:04 PM

Closed by commit rDVAUc8b9c6fdc4a2: api/server: Drop dead code (authored by ardumont). · Explain WhyApr 13 2022, 4:35 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAUc8b9c6fdc4a2: api/server: Drop dead code.