Page MenuHomeSoftware Heritage

add-forge-now: Fix create request checkbox input name
ClosedPublic

Authored by ardumont on Mar 23 2022, 11:50 AM.

Details

Summary

Prior to this, the name was wrong which prevented the actual username consent from being
saved.

Test Plan

tox, cypress happy

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27741
Build 43423: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43422: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7414 (id=26820)

Rebasing onto 716df4a9d7...

Current branch diff-target is up to date.
Changes applied before test
commit 9399ba5602f37a24a19b8a16c78703cbc3d22ed0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Mar 23 11:37:49 2022 +0100

    add-forge-now: Fix create request checkbox input name
    
    Prior to this, the name was wrong which prevented the actual username consent from being
    saved.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1550/ for more details.

This revision is now accepted and ready to land.Mar 23 2022, 12:18 PM

Why is it "on"/"off" instead of a boolean?

Why is it "on"/"off" instead of a boolean?

what can i say besides it's the default value somehow ;)

And i guess that's also have to do with the fact that we don't let django use form to create the dom part.
We just use our own.