Differential D7403

Allow no comment when submitting a new add forge creation request
ClosedPublic
Actions

Authored by ardumont on Mar 21 2022, 5:23 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Maniphest Tasks

T4057: Make forge create request comment optional in the backend

Commits

rDWAPPS60666aa2d1aa: Allow no comment when submitting a new add forge creation request

Summary

Related to T4057

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27641
Build 43269: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43268: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 21 2022, 5:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 21 2022, 5:23 PM

Link to the correct task, reword the help sentence about the comment textarea

ardumont edited the summary of this revision. (Show Details)Mar 21 2022, 5:32 PM

ardumont added a task: T4057: Make forge create request comment optional in the backend.

ardumont removed a task: T4056: Add new model field to store user consent.

Build is green

Patch application report for D7403 (id=26745)

Rebasing onto 82d7c4bd39...

Current branch diff-target is up to date.

Changes applied before test

commit 90b0b309a71ca57350a11bd837c05796b0ea43cb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Mar 21 17:22:20 2022 +0100

    Allow no comment when submitting a new add forge creation request
    
    Related to T4056

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1520/ for more details.

Harbormaster completed remote builds in B27640: Diff 26745.Mar 21 2022, 5:40 PM

Build is green

Patch application report for D7403 (id=26746)

Rebasing onto 82d7c4bd39...

Current branch diff-target is up to date.

Changes applied before test

commit 60666aa2d1aacdc0b8306ecf92009a44c46fa9a0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Mar 21 17:22:20 2022 +0100

    Allow no comment when submitting a new add forge creation request
    
    Related to T4057

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1521/ for more details.

Harbormaster completed remote builds in B27641: Diff 26746.Mar 21 2022, 5:50 PM

ardumont requested review of this revision.Mar 21 2022, 5:50 PM

jayeshv accepted this revision as: jayeshv.Mar 22 2022, 10:19 AM

This revision is now accepted and ready to land.Mar 22 2022, 10:19 AM

Closed by commit rDWAPPS60666aa2d1aa: Allow no comment when submitting a new add forge creation request (authored by ardumont). · Explain WhyMar 22 2022, 10:51 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS60666aa2d1aa: Allow no comment when submitting a new add forge creation request.