Differential D7363

Fix assertion error
ClosedPublic
Actions

Authored by ardumont on Mar 16 2022, 4:21 PM.

Details

Reviewers

vlorentz

Maniphest Tasks

T4013: Re-run deposit loaders tasks with corrupt metadata

Commits

rDDEP6f37ab6eb7c1: Fix assertion error

Summary

Feel free to propose a better commit message, i don't know what to say.

Related to T4013#80910

Test Plan

Hot-patching staging deposit fixed those deposits

T4013#81003

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 16 2022, 4:21 PM

ardumont mentioned this in T4013: Re-run deposit loaders tasks with corrupt metadata.Mar 16 2022, 4:23 PM

Build is green

Patch application report for D7363 (id=26619)

Rebasing onto 5d7f679534...

Current branch diff-target is up to date.

Changes applied before test

commit 6f37ab6eb7c1efe12c4fad00f16325af9b7ca85f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Mar 16 16:19:12 2022 +0100

    Fix assertion error
    
    Related to T4013#80910

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/819/ for more details.

Harbormaster completed remote builds in B27501: Diff 26619.Mar 16 2022, 4:27 PM

ardumont requested review of this revision.Mar 16 2022, 4:27 PM

ardumont edited the summary of this revision. (Show Details)Mar 16 2022, 4:28 PM

ardumont edited the test plan for this revision. (Show Details)Mar 16 2022, 6:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2022, 6:06 PM

Closed by commit rDDEP6f37ab6eb7c1: Fix assertion error (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP6f37ab6eb7c1: Fix assertion error.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

api/

private/

deposit_read.py

2 lines

Diff 26622

View Options

swh/deposit/api/private/deposit_read.py

Fix assertion errorClosedPublicActions