Page MenuHomeSoftware Heritage

backfill: Add missing raw_manifest to directories
ClosedPublic

Authored by vlorentz on Mar 16 2022, 12:25 PM.

Details

Summary

This was not covered by tests so far, because
swh.model.tests.swh_model_data.TEST_OBJECTS did not contain
any object with a raw_manifest.

But it will in swh-model > 5.0.0 (thanks to D7358)

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7359 (id=26590)

Could not rebase; Attempt merge onto 77f7e6d10a...

Updating 77f7e6d1..98b41c85
Fast-forward
 swh/storage/backfill.py | 55 +++++++++++++++++++++++++++++--------------------
 1 file changed, 33 insertions(+), 22 deletions(-)
Changes applied before test
commit 98b41c854968a0fcbb68d1f65279ea2a0081fccf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 16 12:24:33 2022 +0100

    backfill: Add missing raw_manifest to directories
    
    This was not covered by tests so far, because
    swh.model.tests.swh_model_data.TEST_OBJECTS did not contain
    any object with a raw_manifest.
    
    But it will in swh-model > 5.0.0

commit 8b65e42f5adbeef9fd1ef8e28a908c82ee77204f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 16:56:40 2022 +0100

    backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS
    
    Without the type annotation, mypy errors with 'Cannot call function of unknown type'
    when called from a type-checked function.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1576/ for more details.

This revision is now accepted and ready to land.Mar 16 2022, 1:38 PM