Differential D7343

Add a --non-interactive flag to the `swh db upgrade` command
ClosedPublic
Actions

Authored by douardda on Mar 14 2022, 11:38 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE89d7442beacb: Fix a typo
rDCOREe2415c009f12: Add a --(non-)interactive flag to the `swh db upgrade` command

Summary

so it can be used in a script (e.g. docker entrypoint).

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 27431
Build 42928: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42927: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 14 2022, 11:38 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 14 2022, 11:38 AM

Build is green

Patch application report for D7343 (id=26544)

Rebasing onto f40adde2a9...

Current branch diff-target is up to date.

Changes applied before test

commit ed2b54ebc5799e38315da63176ba5eeb9af3a850
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Mar 14 11:35:57 2022 +0100

    Add a --non-interactive flag to the `swh db upgrade` command
    
    so it can be used in a script (e.g. docker entrypoint).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/376/ for more details.

Harbormaster completed remote builds in B27425: Diff 26544.Mar 14 2022, 11:39 AM

douardda requested review of this revision.Mar 14 2022, 11:39 AM

vlorentz added a subscriber: vlorentz.Mar 14 2022, 12:18 PM

vlorentz added inline comments.

swh/core/cli/db.py
325–332	what about this? It doesn't significantly change the interface, and makes the code easier to understand IMO

douardda added inline comments.Mar 14 2022, 1:30 PM

swh/core/cli/db.py
325–332	what about this? It doesn't significantly change the interface, and makes the code easier to understand IMO agreed, thx

update according to vlorentz' suggestion

Build is green

Patch application report for D7343 (id=26547)

Rebasing onto f40adde2a9...

Current branch diff-target is up to date.

Changes applied before test

commit e2415c009f12fda8708d252b25b53f4411336e9a
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Mar 14 11:35:57 2022 +0100

    Add a --(non-)interactive flag to the `swh db upgrade` command
    
    so it can be used in a script (e.g. docker entrypoint).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/377/ for more details.

Harbormaster completed remote builds in B27428: Diff 26547.Mar 14 2022, 1:36 PM

Include a small (unrelated) typo fix

Build is green

Patch application report for D7343 (id=26550)

Rebasing onto f40adde2a9...

Current branch diff-target is up to date.

Changes applied before test

commit 89d7442beacb9dc6220e3377715609aef262a5b0
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Mar 14 13:36:34 2022 +0100

    Fix a typo

commit e2415c009f12fda8708d252b25b53f4411336e9a
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Mar 14 11:35:57 2022 +0100

    Add a --(non-)interactive flag to the `swh db upgrade` command
    
    so it can be used in a script (e.g. docker entrypoint).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/378/ for more details.

Harbormaster completed remote builds in B27431: Diff 26550.Mar 14 2022, 1:40 PM

vlorentz accepted this revision.Mar 14 2022, 2:06 PM

This revision is now accepted and ready to land.Mar 14 2022, 2:06 PM

Closed by commit rDCOREe2415c009f12: Add a --(non-)interactive flag to the `swh db upgrade` command (authored by douardda). · Explain WhyMar 14 2022, 5:18 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCOREe2415c009f12: Add a --(non-)interactive flag to the `swh db upgrade` command.

douardda added a commit: rDCORE89d7442beacb: Fix a typo.