Differential D7304

deposit: Properly escape URLs
ClosedPublic
Actions

Authored by vlorentz on Mar 4 2022, 6:53 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDICP77273580c8b1: deposit: Properly escape URLs

Summary

The '+' character in the 'after' was not escaped, so the server interpreted
it as a space.

Diff Detail

Repository

rDICP Icinga plugins

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27314
Build 42727: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42726: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 4 2022, 6:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2022, 6:53 PM

Build is green

Patch application report for D7304 (id=26427)

Rebasing onto 2676ebba5a...

Current branch diff-target is up to date.

Changes applied before test

commit 77273580c8b10910daa590b7a893c65223ed3ec5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 18:52:52 2022 +0100

    deposit: Properly escape URLs
    
    The '+' character in the 'after' was not escaped, so the server interpreted
    it as a space.

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/66/ for more details.

Harbormaster completed remote builds in B27314: Diff 26427.Mar 4 2022, 6:54 PM

vlorentz requested review of this revision.Mar 4 2022, 6:54 PM