It's a global constant, so it makes more sense to uppercase it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rDICP Icinga plugins
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27290 Build 42691: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 42690: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7297 (id=26403)
Could not rebase; Attempt merge onto 27a2ef97c1...
Updating 27a2ef9..a35d451 Fast-forward swh/icinga_plugins/tests/test_vault.py | 60 +++++++++++++++++++++----------- swh/icinga_plugins/tests/web_scenario.py | 12 ++++--- swh/icinga_plugins/vault.py | 47 +++++++++++++++++++------ 3 files changed, 83 insertions(+), 36 deletions(-)
Changes applied before test
commit a35d451e716c127ce47cd10f41bb0a87f6056d69
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 4 15:45:54 2022 +0100
Rename dir_id to DIR_ID
It's a global constant, so it makes more sense to uppercase it.
commit 514a37ff6830e287f85ee2046bdf65b5e2ddbd82
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 4 15:17:43 2022 +0100
vault: Check bundle download from the public API.See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/54/ for more details.
Comment Actions
Build is green
Patch application report for D7297 (id=26408)
Could not rebase; Attempt merge onto c698de2711...
Updating c698de2..de78c81 Fast-forward swh/icinga_plugins/tests/test_vault.py | 36 +++++++------- swh/icinga_plugins/vault.py | 90 +++++++++++++++++----------------- 2 files changed, 63 insertions(+), 63 deletions(-)
Changes applied before test
commit de78c81353f3cd51b7a5ea9054ed8b808fe0f3a1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 4 16:06:36 2022 +0100
Rename dir_id to DIR_ID
It's a global constant, so it makes more sense to uppercase it.
commit b84160621e62ee2900e8b8ae19f14d6f5c3ff4e7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 4 16:04:51 2022 +0100
vault: Un-nest checks
This will allow more checks later, while keeping the code flow linear.See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/59/ for more details.