Differential D7294

Group vault configuration in a sub-dict
AbandonedPublic
Actions

Authored by vlorentz on Mar 4 2022, 2:19 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

For consistency with other packages
To unbreak the current configuration in prod and staging, which already only passes the 'vault' sub-dict.

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27285
Build 42681: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42680: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 4 2022, 2:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2022, 2:19 PM

Build is green

Patch application report for D7294 (id=26398)

Could not rebase; Attempt merge onto df35ac0601...

Updating df35ac0..3e7ee3d
Fast-forward
 conftest.py                    |  1 -
 swh/vault/api/server.py        |  4 ++--
 swh/vault/backend.py           |  2 +-
 swh/vault/cli.py               |  6 +++---
 swh/vault/tests/conftest.py    | 44 ++++++++++++++++++++----------------------
 swh/vault/tests/test_init.py   |  4 ++--
 swh/vault/tests/test_server.py | 18 ++++-------------
 7 files changed, 33 insertions(+), 46 deletions(-)

Changes applied before test

commit 3e7ee3dcdb17e0497821c89ac6bb40e709e79e6e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 14:19:09 2022 +0100

    Group vault configuration in a sub-dict
    
    1. For consistency with other packages
    2. To unbreak the current configuration in prod and staging, which already only
       passes the 'vault' sub-dict.

commit 7835980b5bcce742969737e2bb1df38e98a58c70
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 13:31:09 2022 +0100

    Finish removing aiohttp

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/224/ for more details.

Harbormaster completed remote builds in B27285: Diff 26398.Mar 4 2022, 2:21 PM

vlorentz requested review of this revision.Mar 4 2022, 2:21 PM

olasd mentioned this in D7296: server: ensure check_config is called during app instantiation.Mar 4 2022, 3:39 PM

vlorentz abandoned this revision.Mar 4 2022, 4:44 PM