Page MenuHomeSoftware Heritage

search QL: Raise 400 instead of 500 on syntax error
ClosedPublic

Authored by vlorentz on Mar 3 2022, 5:24 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rDWAPPS7e5b06ff77ed: search QL: Raise 400 instead of 500 on syntax error

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D7286 (id=26374)

Rebasing onto 57a83b9a7f...

Current branch diff-target is up to date.
Changes applied before test
commit b1516ec318ca8fdfc290c019413f768c22071b39
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 3 17:23:53 2022 +0100

    search QL: Raise 400 instead of 500 on syntax error

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1414/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1414/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2022, 5:25 PM
Harbormaster failed remote builds in B27258: Diff 26374!

Build has FAILED

Patch application report for D7286 (id=26374)

Rebasing onto 57a83b9a7f...

Current branch diff-target is up to date.
Changes applied before test
commit b1516ec318ca8fdfc290c019413f768c22071b39
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 3 17:23:53 2022 +0100

    search QL: Raise 400 instead of 500 on syntax error

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1415/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1415/console

Build is green

Patch application report for D7286 (id=26374)

Rebasing onto 57a83b9a7f...

Current branch diff-target is up to date.
Changes applied before test
commit b1516ec318ca8fdfc290c019413f768c22071b39
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 3 17:23:53 2022 +0100

    search QL: Raise 400 instead of 500 on syntax error

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1416/ for more details.

vlorentz added a task: Restricted Maniphest Task.Mar 7 2022, 9:22 AM
This revision is now accepted and ready to land.Mar 7 2022, 1:54 PM
This revision was landed with ongoing or failed builds.Mar 8 2022, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7286 (id=26444)

Rebasing onto 7e5b06ff77...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1419-D7286.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1419/ for more details.