Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDDEP1fe5bf191360: Warn about missing <swh:metadata-provenance> even on unrelated errors
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7263 (id=26310)
Could not rebase; Attempt merge onto ccff46762b...
Updating ccff4676..bf720567 Fast-forward MANIFEST.in | 1 + docs/specs/protocol-reference.rst | 4 +- docs/specs/spec-loading.rst | 4 +- docs/specs/swh.xsd | 60 --- mypy.ini | 3 + requirements-server.txt | 1 + swh/deposit/api/checks.py | 57 ++- swh/deposit/tests/api/test_checks.py | 546 +++++++++++++++++++-- .../{tests_migration => tests}/test_migrations.py | 0 swh/deposit/xsd/codemeta.xsd | 36 ++ swh/deposit/xsd/swh.xsd | 81 +++ 11 files changed, 669 insertions(+), 124 deletions(-) delete mode 100644 docs/specs/swh.xsd rename swh/deposit/{tests_migration => tests}/test_migrations.py (100%) create mode 100644 swh/deposit/xsd/codemeta.xsd create mode 100644 swh/deposit/xsd/swh.xsd
Changes applied before test
commit bf72056748945c4919be30111d5744a834bc3472 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Feb 28 10:30:08 2022 +0100 Warn about missing <swh:metadata-provenance> even on unrelated errors This behavior was (accidentally) removed in 74d5567b31f4e72d37d33b424ff7a8dc57d06b02. commit 841233902d2b6d9a96f08cc6f3341e4c7c4cd0ca Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 16:57:55 2022 +0100 docs: Fix invalid format of codemeta:contributor in an example commit 7b3fcb9330040865fb3b7b8116ad9b59edce063a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 16:44:53 2022 +0100 Make codemeta:name mandatory in codemeta:author and codemeta:contributor commit d72933b01a11d05ac806baf904353b743b048999 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 16:23:43 2022 +0100 Add basic validation for codemeta:author and codemeta:contributor For now, this only checks they aren't just a string commit 25d75f1cb9c67dd372a2618b51b853cf2a04d2dd Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 16:15:40 2022 +0100 Validate codemeta:name This only checks the name is a string. commit d8cf768a0ea2e7b078406d4d7f8fb90efbb37c82 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 16:04:43 2022 +0100 Validate codemeta:dateModified. commit 74d5567b31f4e72d37d33b424ff7a8dc57d06b02 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 15:57:40 2022 +0100 Use xmlschema to validate dates, instead of custom code. For now this increases code complexity, but this will allow addition of other check more easily. commit b49d5e6ab16bdc53bfcd7b942e4feebac7b19cf8 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 13:35:42 2022 +0100 Enforce create_origin/add_to_origin/reference are mutually exclusive in the schema commit e087956040e35eee914135b4ec2871b04dd192c4 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 13:30:33 2022 +0100 Add schema validation of <swh:deposit> using swh.xsd commit 0a6c03965a7a5446884ca07d21b7e03d6ab145c4 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 13:24:10 2022 +0100 Improve readability of pytest errors by removing unnecessary whitespaces The leading newline prevented textwrap.dedent from removing them. commit 2e95623c6c7783ed407fa721f09289742ecccab8 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 12:13:50 2022 +0100 Fix swh.xsd It was never actually tested... commit 8a7e0832641bda3b4c445793cfb92e3de6c5947e Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Feb 24 12:04:03 2022 +0100 Move tests_migration/test_migrations.py to tests/test_migrations.py This fixes crashes when running 'pytest -k migration', because swh/deposit/tests_migration/ lacks a conftest to initialize the database.
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/791/ for more details.
Comment Actions
Build is green
Patch application report for D7263 (id=26449)
Rebasing onto 1fe5bf1913...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-796-D7263.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/796/ for more details.