Page MenuHomeSoftware Heritage

Let the log instruction do the formatting
ClosedPublic

Authored by ardumont on Feb 18 2022, 12:33 PM.

Details

Summary

And use f-string when raising

That avoids issue with the wrong string like "('Directory %s does not contain any valid
RCS files %s', '/tmp/swh.loader.cvs.vlhhs33r-478777')"

Test Plan

tox still happy

Diff Detail

Repository
rDLDCVS CVS Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26981
Build 42186: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42185: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7199 (id=26108)

Rebasing onto 3beb8b1d9c...

Current branch diff-target is up to date.
Changes applied before test
commit aea6e49ffd4a6930a24e759361d113c1034dc807
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 18 12:30:34 2022 +0100

    Let the log instruction do the formatting
    
    And use f-string when raising

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/94/ for more details.

This revision is now accepted and ready to land.Feb 18 2022, 12:52 PM