Differential D7156

Make RemoteSearch reraise specific exceptions instead of generic RemoteException
ClosedPublic
Actions

Authored by vlorentz on Feb 11 2022, 1:38 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Summary

This will allow us to implement better exception handling in swh-web,
instead of erroring with HTTP 500

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26820
Build 41920: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41919: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 11 2022, 1:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 11 2022, 1:38 PM

vlorentz added a task: Restricted Maniphest Task.Feb 11 2022, 1:38 PM

remove non-exception objects from reraise_exceptions list

Build is green

Patch application report for D7156 (id=25942)

Rebasing onto ea76213651...

Current branch diff-target is up to date.

Changes applied before test

commit 3719bd75d802405a9cd702ecfe578b7a9699c89f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 11 13:37:41 2022 +0100

    Make RemoteSearch reraise specific exceptions instead of generic RemoteException
    
    This will allow us to implement better exception handling in swh-web,
    instead of erroring with HTTP 500

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/305/ for more details.

Harbormaster completed remote builds in B26819: Diff 25942.Feb 11 2022, 1:42 PM

Build is green

Patch application report for D7156 (id=25943)

Rebasing onto ea76213651...

Current branch diff-target is up to date.

Changes applied before test

commit 96804d0ce5b21aa6cdb1efc5263478a635995658
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Feb 11 13:37:41 2022 +0100

    Make RemoteSearch reraise specific exceptions instead of generic RemoteException
    
    This will allow us to implement better exception handling in swh-web,
    instead of erroring with HTTP 500

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/306/ for more details.

Harbormaster completed remote builds in B26820: Diff 25943.Feb 11 2022, 1:44 PM

vlorentz requested review of this revision.Feb 11 2022, 1:44 PM

anlambert accepted this revision.Feb 11 2022, 2:08 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.