Differential D7134

tests: Reorganize test files and utils
ClosedPublic
Actions

Authored by anlambert on Feb 9 2022, 3:40 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNb5769ef7d6eb: tests: Reorganize test files and utils

Summary

Add utils.py file holding add_commit and create_repo functions.

Move repo_url pytest fixture in conftest.py.

Move externals related tests in a dedicated test_externals.py file.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 9 2022, 3:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 9 2022, 3:40 PM

Build is green

Patch application report for D7134 (id=25865)

Rebasing onto d7a97a75a6...

Current branch diff-target is up to date.

Changes applied before test

commit eee67ff4b192fe97bc44d4aa897e996520c06d29
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Feb 9 15:40:15 2022 +0100

    tests: Reorganize test files and utils
    
    Add utils.py file holding add_commit and create_repo functions.
    
    Move repo_url pytest fixture in conftest.py.
    
    Move externals related tests in a dedicated test_externals.py file.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/297/ for more details.

Harbormaster completed remote builds in B26707: Diff 25865.Feb 9 2022, 3:42 PM

anlambert requested review of this revision.Feb 9 2022, 3:42 PM

ardumont accepted this revision.Feb 9 2022, 4:21 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/loader/svn/tests/utils.py
74–75	merge the 2 lines?

This revision is now accepted and ready to land.Feb 9 2022, 4:21 PM

Simplify create_repo function

Build is green

Patch application report for D7134 (id=25871)

Rebasing onto d7a97a75a6...

Current branch diff-target is up to date.

Changes applied before test

commit b5769ef7d6ebfdf6a2cee2bc8c79866e650c6d97
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Feb 9 15:40:15 2022 +0100

    tests: Reorganize test files and utils
    
    Add utils.py file holding add_commit and create_repo functions.
    
    Move repo_url pytest fixture in conftest.py.
    
    Move externals related tests in a dedicated test_externals.py file.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/298/ for more details.

Harbormaster completed remote builds in B26713: Diff 25871.Feb 9 2022, 4:43 PM

Closed by commit rDLDSVNb5769ef7d6eb: tests: Reorganize test files and utils (authored by anlambert). · Explain WhyFeb 9 2022, 4:45 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNb5769ef7d6eb: tests: Reorganize test files and utils.