Differential D7126

git_bare: Add support for releases as root object.
ClosedPublic
Actions

Authored by vlorentz on Feb 8 2022, 5:43 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDVAU08018cf5e005: git_bare: Add support for releases as root object.

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26683
Build 41725: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41724: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 8 2022, 5:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 5:43 PM

vlorentz mentioned this in D7122: Allow cooking release objects via the API.Feb 8 2022, 5:44 PM

vlorentz added a child revision: D7122: Allow cooking release objects via the API.

Build is green

Patch application report for D7126 (id=25840)

Rebasing onto 161a55d76c...

Current branch diff-target is up to date.

Changes applied before test

commit 08018cf5e005b035e67b2ce263e1b5f4ee19d702
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Feb 8 17:43:32 2022 +0100

    git_bare: Add support for releases as root object.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/206/ for more details.

Harbormaster completed remote builds in B26683: Diff 25840.Feb 8 2022, 5:45 PM

vlorentz requested review of this revision.Feb 8 2022, 5:45 PM

Looks good to me.

swh/vault/cookers/git_bare.py
279	Non ascii release names are forbidden by git ?

This revision is now accepted and ready to land.Feb 9 2022, 11:26 AM

vlorentz added inline comments.Feb 10 2022, 11:04 AM

swh/vault/cookers/git_bare.py
279	They might be, but it's going to cause encoding issues, so I'd rather not

Closed by commit rDVAU08018cf5e005: git_bare: Add support for releases as root object. (authored by vlorentz). · Explain WhyFeb 10 2022, 11:04 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU08018cf5e005: git_bare: Add support for releases as root object..

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

vault/

cookers/

git_bare.py

65 lines

91%

tests/

test_git_bare_cooker.py

139 lines

98%

Diff 25840

View Options

swh/vault/cookers/git_bare.py