Differential D7117

Add bzr loader task
ClosedPublic
Actions

Authored by Alphare on Feb 8 2022, 10:41 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBZR078fb5029667: Add bzr loader task

Diff Detail

Repository

rDLDBZR BZR loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Feb 8 2022, 10:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 10:41 AM

Build is green

Patch application report for D7117 (id=25803)

Rebasing onto 48c0b22ce8...

Current branch diff-target is up to date.

Changes applied before test

commit 595ff13eb5d1a20582c74ea0652c2875265944ab
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:40:36 2022 +0100

    Add bzr loader task

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/26/ for more details.

Harbormaster completed remote builds in B26647: Diff 25803.Feb 8 2022, 10:46 AM

Alphare requested review of this revision.Feb 8 2022, 10:46 AM

lgtm

Which bzr loader ingestion is it triggering (incremental or not)?

This revision is now accepted and ready to land.Feb 8 2022, 10:50 AM

ah but wait...
visit_date is not in the right format.

This revision now requires changes to proceed.Feb 8 2022, 10:51 AM

ardumont added inline comments.Feb 8 2022, 10:52 AM

swh/loader/bzr/tasks.py
15	loader constructor expects a datetime here. So this needs parsing with the utility function you moved to loader-core.

In D7117#185144, @ardumont wrote:

lgtm

Which bzr loader ingestion is it triggering (incremental or not)?

This triggers the incremental loader. There is no argument to force the incremental loader to do a full load if there already was a snapshot. Should there?

swh/loader/bzr/tasks.py
15	Will do

Use parse_visit_date from loader-core

This will need a bump in version from loader-core

This triggers the incremental loader.

There is no argument to force the incremental loader to do a full load if there already was a snapshot. Should there?

Let this be as is, we'll see if we need one.
We finally open that option (force the full loading) in the svn loader when there was a need for it.

Thanks ;)

Build is green

Patch application report for D7117 (id=25805)

Rebasing onto 48c0b22ce8...

Current branch diff-target is up to date.

Changes applied before test

commit 078fb5029667a3adce686982e16071d4d16e2978
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:40:36 2022 +0100

    Add bzr loader task

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B26649: Diff 25805.Feb 8 2022, 11:00 AM

ardumont accepted this revision.Feb 8 2022, 11:00 AM

This revision is now accepted and ready to land.Feb 8 2022, 11:00 AM

ardumont mentioned this in T3915: Deploy Bzr loader to the staging environment.Feb 8 2022, 11:19 AM

Closed by commit rDLDBZR078fb5029667: Add bzr loader task (authored by Alphare). · Explain WhyFeb 8 2022, 11:20 AM

This revision was automatically updated to reflect the committed changes.

Alphare added a commit: rDLDBZR078fb5029667: Add bzr loader task.