Page MenuHomeSoftware Heritage

Add bzr loader task
ClosedPublic

Authored by Alphare on Feb 8 2022, 10:41 AM.

Details

Diff Detail

Repository
rDLDBZR BZR loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26649
Build 41675: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41674: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7117 (id=25803)

Rebasing onto 48c0b22ce8...

Current branch diff-target is up to date.
Changes applied before test
commit 595ff13eb5d1a20582c74ea0652c2875265944ab
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:40:36 2022 +0100

    Add bzr loader task

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/26/ for more details.

ardumont added a subscriber: ardumont.

lgtm

Which bzr loader ingestion is it triggering (incremental or not)?

This revision is now accepted and ready to land.Feb 8 2022, 10:50 AM

ah but wait...
visit_date is not in the right format.

This revision now requires changes to proceed.Feb 8 2022, 10:51 AM
swh/loader/bzr/tasks.py
15

loader constructor expects a datetime here.
So this needs parsing with the utility function you moved to loader-core.

lgtm

Which bzr loader ingestion is it triggering (incremental or not)?

This triggers the incremental loader. There is no argument to force the incremental loader to do a full load if there already was a snapshot. Should there?

swh/loader/bzr/tasks.py
15

Will do

Use parse_visit_date from loader-core

This will need a bump in version from loader-core

This triggers the incremental loader.

ok

There is no argument to force the incremental loader to do a full load if there already was a snapshot. Should there?

Let this be as is, we'll see if we need one.
We finally open that option (force the full loading) in the svn loader when there was a need for it.

Thanks ;)

Build is green

Patch application report for D7117 (id=25805)

Rebasing onto 48c0b22ce8...

Current branch diff-target is up to date.
Changes applied before test
commit 078fb5029667a3adce686982e16071d4d16e2978
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:40:36 2022 +0100

    Add bzr loader task

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/27/ for more details.

This revision is now accepted and ready to land.Feb 8 2022, 11:00 AM
This revision was automatically updated to reflect the committed changes.