Differential D7076

archive: Pass limit as a keyword parameter to storage.revision_log
ClosedPublic
Actions

Authored by anlambert on Feb 3 2022, 4:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSeebb27ebdb44: archive: Pass limit as a keyword parameter to storage.revision_log

Summary

Signature of storage.revision_log has changed in 4544d7ca8e9e and the
limit parameter is not at the same position as before, so better
passing it as keyword parameter to avoid future errors of this type.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 3 2022, 4:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 3 2022, 4:03 PM

anlambert mentioned this in D7073: auth: Add UserMailmap model and edition endpoints.Feb 3 2022, 4:04 PM

ardumont published this revision for review.Feb 3 2022, 4:08 PM

ardumont accepted this revision.

This revision is now accepted and ready to land.Feb 3 2022, 4:08 PM

ardumont mentioned this in D7066: origin_visits: Reuse cache entries if present.Feb 3 2022, 4:09 PM

Build is green

Patch application report for D7076 (id=25669)

Rebasing onto f990d789aa...

Current branch diff-target is up to date.

Changes applied before test

commit eebb27ebdb442c74a2bc0a9905c59c5f9b2235f4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Feb 3 15:58:47 2022 +0100

    archive: Pass limit as a keyword parameter to storage.revision_log
    
    Signature of storage.revision_log has changed in 4544d7ca8e9e and the
    limit parameter is not at the same position as before, so better
    passing it as keyword parameter to avoid future errors of this type.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1317/ for more details.

Harbormaster completed remote builds in B26501: Diff 25669.Feb 3 2022, 4:18 PM

Closed by commit rDWAPPSeebb27ebdb44: archive: Pass limit as a keyword parameter to storage.revision_log (authored by anlambert). · Explain WhyFeb 3 2022, 4:35 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSeebb27ebdb44: archive: Pass limit as a keyword parameter to storage.revision_log.

ardumont mentioned this in T3905: icinga end-to-end (loader) check reports are off.Feb 4 2022, 4:00 PM