We need to use the original names for commit/tag content to match their hash;
otherwise git-fsck/git-clone would error and make cooked repositories
unusable.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDVAUcbad3b9da831: git_bare: Use original author names instead of display names
The 'with-graph' test depends will fail, as it depends on D7070.
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26486 Build 41418: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41417: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D7071 (id=25656)
Could not rebase; Attempt merge onto 1da8cbe0a9...
Updating 1da8cbe..042735a Fast-forward requirements-swh.txt | 2 +- swh/vault/cookers/git_bare.py | 29 ++++--- swh/vault/tests/test_cookers.py | 117 +++++++++++++++++++++++++++- swh/vault/tests/test_git_bare_cooker.py | 133 ++++++++++++++++++++++++++++++++ 4 files changed, 268 insertions(+), 13 deletions(-)
Changes applied before test
commit 042735ace5ef4dc8325b98f5fcbf2882e928bc48
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Feb 3 11:52:54 2022 +0100
git_bare: Use original author names instead of display names
We need to use the original names for commit/tag content to match their hash;
otherwise git-fsck/git-clone would error and make cooked repositories
unusable.
commit b8d825325d84a4417b6a71aabb1d591d347772e0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Feb 2 18:31:06 2022 +0100
git_bare: Use raw_manifest when available
This allows restoring objects as-is, so they match checksums;
even when the parser was lossy.Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/202/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/202/console
| swh/vault/tests/test_git_bare_cooker.py | ||
|---|---|---|
| 473 | it's an object of type Person... | |
Comment Actions
Build has FAILED
Patch application report for D7071 (id=25799)
Rebasing onto cbad3b9da8...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-204-D7071.
Changes applied before test
Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/204/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/204/console