The restoration of this type of file was not correctly handled
in the remove_external_path method of the DirEditor class.
Depends on D7041
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDSVN2bbbd6f99f9c: replay: Fix links restoration in DirEditor.remove_external_path
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Branch
- fix-link-restore-in-remove-external
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26362 Build 41217: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41216: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7042 (id=25530)
Could not rebase; Attempt merge onto afdee6dbee...
Updating afdee6d..2bbbd6f Fast-forward swh/loader/svn/replay.py | 2 +- swh/loader/svn/svn.py | 27 +++++++++++++++++++-------- swh/loader/svn/tests/test_loader.py | 22 ++++++++++++++++++---- 3 files changed, 38 insertions(+), 13 deletions(-)
Changes applied before test
commit 2bbbd6f99f9cd64718bac40a7e78a04c3026c6c3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Wed Jan 26 15:33:17 2022 +0100
replay: Fix links restoration in DirEditor.remove_external_path
The restoration of this type of file was not correctly handled
in the remove_external_path method of the DirEditor class.
commit 34f61cb58157e0cf4a70810a6ef66364b3c2b24e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Wed Jan 26 15:28:54 2022 +0100
svn: Ignore externals parsing related errors when exporting
Those are not critical for a successfull loading of repositories with
malformed external definitions so we can safely ignore them.
Related to T3875See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/271/ for more details.