Page MenuHomeSoftware Heritage

grid5000: fix errors and make it faster
ClosedPublic

Authored by dachary on Jan 24 2022, 3:20 PM.

Details

Summary

As suggested by olasd, with mitogen.

Relates to: T3531

It is weird to add extracts of a python module (mitogen) by copying them. But that's a known requirement of mitogen, see https://github.com/mitogen-hq/mitogen/issues/568

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26315
Build 41146: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41145: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D7026 (id=25463)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit 8228df21a1738e6d19ef2711a5998c79226e06b6
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    As suggested by olasd, with mitogen.
    
    Relates to: T3531

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/108/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/108/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 24 2022, 3:21 PM
Harbormaster failed remote builds in B26299: Diff 25463!

do not flake8 mitogen plugins

Build is green

Patch application report for D7026 (id=25465)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit c6561792040eee2499c138334f01195975377baf
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    As suggested by olasd, with mitogen.
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/109/ for more details.

ensure the SSH key is 600 otherwise it leads to non-intuitive failures

Build is green

Patch application report for D7026 (id=25466)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit 9671e55fb7d644f3a72584fc8f0cc157f2847783
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/110/ for more details.

Could you add a short readme or something in winery-test-environment/mitogen-strategy/, so future reader know the rationale and where this is coming from?

  • Added a README.txt to explain the need for the mitogen plugins
  • Added mitogen as a test dependency

Could you add a short readme or something in winery-test-environment/mitogen-strategy/, so future reader know the rationale and where this is coming from?

Good idea, done!

Build is green

Patch application report for D7026 (id=25480)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit e2bf376fdbd73652987dda2c58dac01d6090c25a
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 18:26:33 2022 +0100

    grid5000: fix errors and make it faster
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/111/ for more details.

This revision is now accepted and ready to land.Jan 25 2022, 10:44 AM
This revision was automatically updated to reflect the committed changes.