Page MenuHomeSoftware Heritage
Differential D7026

grid5000: fix errors and make it faster
ClosedPublic
Actions

Authored by dachary on Jan 24 2022, 3:20 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDOBJS554c12a851ff: grid5000: fix errors and make it faster
Summary

As suggested by olasd, with mitogen.

Relates to: T3531

It is weird to add extracts of a python module (mitogen) by copying them. But that's a known requirement of mitogen, see https://github.com/mitogen-hq/mitogen/issues/568

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26301
Build 41121: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41120: arc lint + arc unit

Event Timeline

dachary created this revision.Jan 24 2022, 3:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2022, 3:20 PM
swh-public-ci added a comment.Jan 24 2022, 3:21 PM

Build has FAILED

Patch application report for D7026 (id=25463)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit 8228df21a1738e6d19ef2711a5998c79226e06b6
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    As suggested by olasd, with mitogen.
    
    Relates to: T3531

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/108/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/108/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 24 2022, 3:21 PM
Harbormaster failed remote builds in B26299: Diff 25463!
dachary updated this revision to Diff 25465.Jan 24 2022, 3:40 PM

do not flake8 mitogen plugins

swh-public-ci added a comment.Jan 24 2022, 3:42 PM

Build is green

Patch application report for D7026 (id=25465)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit c6561792040eee2499c138334f01195975377baf
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    As suggested by olasd, with mitogen.
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/109/ for more details.

Harbormaster completed remote builds in B26301: Diff 25465.Jan 24 2022, 3:42 PM
dachary requested review of this revision.Jan 24 2022, 3:42 PM
dachary edited the summary of this revision. (Show Details)Jan 24 2022, 3:44 PM
dachary updated this revision to Diff 25466.Jan 24 2022, 4:01 PM

ensure the SSH key is 600 otherwise it leads to non-intuitive failures

swh-public-ci added a comment.Jan 24 2022, 4:03 PM

Build is green

Patch application report for D7026 (id=25466)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit 9671e55fb7d644f3a72584fc8f0cc157f2847783
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 15:18:36 2022 +0100

    grid5000: fix errors and make it faster
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/110/ for more details.

Harbormaster completed remote builds in B26302: Diff 25466.Jan 24 2022, 4:03 PM
vlorentz added a subscriber: vlorentz.Jan 24 2022, 5:02 PM

Could you add a short readme or something in winery-test-environment/mitogen-strategy/, so future reader know the rationale and where this is coming from?

dachary updated this revision to Diff 25480.Jan 24 2022, 6:27 PM
  • Added a README.txt to explain the need for the mitogen plugins
  • Added mitogen as a test dependency
dachary added a comment.Jan 24 2022, 6:27 PM
In D7026#182606, @vlorentz wrote:

Could you add a short readme or something in winery-test-environment/mitogen-strategy/, so future reader know the rationale and where this is coming from?

Good idea, done!

swh-public-ci added a comment.Jan 24 2022, 6:29 PM

Build is green

Patch application report for D7026 (id=25480)

Rebasing onto 5904f7c155...

Current branch diff-target is up to date.
Changes applied before test
commit e2bf376fdbd73652987dda2c58dac01d6090c25a
Author: Loïc Dachary <loic@dachary.org>
Date:   Mon Jan 24 18:26:33 2022 +0100

    grid5000: fix errors and make it faster
    
    Relates to: T3531

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/111/ for more details.

Harbormaster completed remote builds in B26315: Diff 25480.Jan 24 2022, 6:29 PM
vlorentz accepted this revision.Jan 25 2022, 10:44 AM
This revision is now accepted and ready to land.Jan 25 2022, 10:44 AM
Closed by commit rDOBJS554c12a851ff: grid5000: fix errors and make it faster (authored by dachary). · Explain WhyJan 25 2022, 10:50 AM
This revision was automatically updated to reflect the committed changes.
dachary added a commit: rDOBJS554c12a851ff: grid5000: fix errors and make it faster.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
1 line--
1 line--
winery-test-environment/
2 lines--
1 line--
mitogen-strategy/
100%
Loading...
61 lines--
62 lines--
67 lines--
62 lines--

Diff 25465

View Options

.pre-commit-config.yaml

Loading...
View Options

setup.cfg

Loading...
View Options

tox.ini

Loading...
View Options

winery-test-environment/ansible.cfg

Loading...
View Options

winery-test-environment/grid5000.yml

Loading...
View Options

winery-test-environment/mitogen-strategy/__init__.py

Loading...
View Options

winery-test-environment/mitogen-strategy/mitogen.py

Loading...
View Options

winery-test-environment/mitogen-strategy/mitogen_free.py

Loading...
View Options

winery-test-environment/mitogen-strategy/mitogen_host_pinned.py

Loading...
View Options

winery-test-environment/mitogen-strategy/mitogen_linear.py

Loading...
About · Developer information · Legal