I don't expect directory_get_raw_manifest to be used, but it is needed for tests,
so why not.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTO6f0252465c31: Fix directory_add to actually insert the manifest + add…
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26292 Build 41106: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41105: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7024 (id=25455)
Rebasing onto 5874905742...
Current branch diff-target is up to date.
Changes applied before test
commit 2f364cd7c5a596d9957b3353673d282cc816c28c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 24 12:52:04 2022 +0100
Fix directory_add to actually insert the manifest + add directory_get_raw_manifest
I don't expect directory_get_raw_manifest to be used, but it is needed for tests,
so why not.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1540/ for more details.
Comment Actions
Oof. I guess that's one more reason to be wary of TODOs in tests.
There's a few comments but no show stopper that I can see.
Either way, I guess the vault will want to use directory_get_raw_manifest eventually, so we'd have had to implement this?
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 659–661 | How did that get here? | |
| 692 | "the row (with metadata)? from the main directory table" ? | |
| swh/storage/in_memory.py | ||
| 302 | ReleaseRow? | |
| swh/storage/postgresql/storage.py | ||
| 524 | s/ids/metadata/ | |
Comment Actions
Build is green
Patch application report for D7024 (id=25456)
Rebasing onto 5874905742...
Current branch diff-target is up to date.
Changes applied before test
commit 8e2921944a7c30a1acc3d8f7e6b5e75f4dc59eaf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 24 12:52:04 2022 +0100
Fix directory_add to actually insert the manifest + add directory_get_raw_manifest
I don't expect directory_get_raw_manifest to be used, but it is needed for tests,
so why not.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1541/ for more details.
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 692 | I know, but I had to think a lot about what a "main directory row" would be :-) Maybe just say "Return fields from the main directory table (e.g. raw_manifest)"? | |
Comment Actions
Build is green
Patch application report for D7024 (id=25482)
Rebasing onto 6f0252465c...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-1542-D7024.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1542/ for more details.