Page MenuHomeSoftware Heritage

model: Add support for more edge cases in _parse_offset_bytes
ClosedPublic

Authored by vlorentz on Jan 17 2022, 3:21 PM.

Details

Summary

Needed to recover corrupt objects, while we still have the 'offset' attribute.

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26067
Build 40739: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40738: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6956 (id=25206)

Rebasing onto a0f5436273...

Current branch diff-target is up to date.
Changes applied before test
commit c98c7262e90369b9295c21999ec5fd3217e651d5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 15:20:45 2022 +0100

    model: Add support for more edge cases in _parse_offset_bytes

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/450/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/450/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 17 2022, 3:23 PM
Harbormaster failed remote builds in B26067: Diff 25206!

Looks like sphinx is unhappy from an unrelated change.

swh/model/model.py
455

Missing return value annotation, and probably a docstring or doctests.

rebase + add return type + add doctests

Build is green

Patch application report for D6956 (id=25217)

Rebasing onto e1c3fe8073...

Current branch diff-target is up to date.
Changes applied before test
commit f43f9ac98c092d002502f8a6e2fd3153a545ccd9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 15:20:45 2022 +0100

    model: Add support for more edge cases in _parse_offset_bytes

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/452/ for more details.

This revision is now accepted and ready to land.Jan 18 2022, 11:01 AM