Page MenuHomeSoftware Heritage

Vagrantfile: Explicit the mount point should happen with rsync
ClosedPublic

Authored by ardumont on Jan 11 2022, 6:21 PM.

Details

Summary

Otherwise, puppet fails to mount nfs volumes (using nfs v3 badly supported with bullseye
node [1]).

[1] https://forge.softwareheritage.org/file/info/PHID-FILE-5caqxw3j5rmcpmlene5i/

Related to T3833

Test Plan

Without this diff, see [1]

With it, the vm is mounted without issues:

vagrant reload dali
==> dali: Attempting graceful shutdown of VM...
==> dali: Starting domain.
==> dali: Waiting for domain to get an IP address...
==> dali: Waiting for machine to boot. This may take a few minutes...
    dali: SSH address: 192.168.121.226:22
    dali: SSH username: vagrant
    dali: SSH auth method: private key
==> dali: Machine booted and ready!
==> dali: Creating shared folders metadata...
==> dali: Exporting NFS shared folders...
==> dali: Preparing to edit /etc/exports. Administrator privileges will be required...
[sudo] password for tony:
Sorry, try again.
[sudo] password for tony:
==> dali: Mounting NFS shared folders...
==> dali: Installing rsync to the VM...
==> dali: Rsyncing folder: /tmp/puppet/environments/ => /tmp/vagrant-puppet/environments
==> dali: Rsyncing folder: /home/tony/work/inria/repo/swh/puppet-environment/swh-site/manifests/ => /tmp/vagrant-puppet/manifests-158062c63b8270a305072fe9a8eecc79
==> dali: Running provisioner: shell...
    dali: Running: /tmp/vagrant-shell20220111-598805-yiwcv.sh
    dali: + DEPLOYMENT=admin
    dali: + SUBNET=vagrant
    dali: + FACTS_D=/etc/facter/facts.d
    dali: + '[' '!' -d /etc/facter/facts.d ']'
    dali: + mkdir -p /etc/facter/facts.d
    dali: + echo deployment=admin
    dali: + echo subnet=vagrant
==> dali: Running provisioner: puppet...
==> dali: Running Puppet with environment production...
==> dali: Info: Loading facts
==> dali: Info: Loading facts
==> dali: Info: Loading facts
...

Diff Detail

Repository
rSENV Puppet Environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25941
Build 40541: arc lint + arc unit

Event Timeline

ardumont created this revision.
vsellier added inline comments.
Vagrantfile
589

Perhaps put this line under the L600 to be closed to the relative comment ?

Vagrantfile
589

totally, i did not connect the dot here.
Thanks.

Adapt according to suggestion

This revision is now accepted and ready to land.Jan 12 2022, 11:24 AM

By the way, I had forgotten to check that buster nodes are ok with this.
They still are [1]

$ vagrant up --no-destroy-on-error test
...
==> test: Notice: Applied catalog in 125.52 seconds