Page MenuHomeSoftware Heritage
Differential D6905

Add releases notes (from user-provided Atom document) to release messages.
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2022, 11:35 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3809: Use `releaseNotes` for release artifact message
Commits
rDLDBASE2f9149bc9243: Add releases notes (from user-provided Atom document) to release messages.
Summary

Part 2/2 to resolve T3809

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 11 2022, 11:35 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 11:35 AM
swh-public-ci added a comment.Jan 11 2022, 11:37 AM

Build is green

Patch application report for D6905 (id=25043)

Rebasing onto 4e2e0ab8be...

Current branch diff-target is up to date.
Changes applied before test
commit 2f9149bc9243d5abf7d96b0680ea1b54fab3ac83
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 11:34:34 2022 +0100

    Add releases notes (from user-provided Atom document) to release messages.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/671/ for more details.

Harbormaster completed remote builds in B25913: Diff 25043.Jan 11 2022, 11:37 AM
vlorentz requested review of this revision.Jan 11 2022, 11:37 AM
ardumont accepted this revision.Jan 11 2022, 6:05 PM
ardumont added a subscriber: ardumont.

lgtm

one question inline.

swh/loader/package/deposit/loader.py
201–208

do we want to keep that crafted message at all?
If there is a release note already mentioned, shan't we just keep it as is?

This revision is now accepted and ready to land.Jan 11 2022, 6:05 PM
vlorentz added inline comments.Jan 12 2022, 9:57 AM
swh/loader/package/deposit/loader.py
201–208

I'd rather keep it for consistency between deposits

Closed by commit rDLDBASE2f9149bc9243: Add releases notes (from user-provided Atom document) to release messages. (authored by vlorentz). · Explain WhyJan 12 2022, 1:13 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDBASE2f9149bc9243: Add releases notes (from user-provided Atom document) to release messages..

Revision Contents
Changeset List

PathSize
swh/
loader/
package/
deposit/
14 lines
tests/
data/
https_deposit.softwareheritage.org/
1 line
1 line
3 lines
3 lines
3 lines
hello_2.13.json
hello_2.12.json
7 lines
61 lines

Diff 25084

View Options

swh/loader/package/deposit/loader.py

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/1_private_999_meta

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/1_private_999_raw

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/hello_2.10.json

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/hello_2.11.json

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/hello_2.12.json

Loading...
View Options

swh/loader/package/deposit/tests/data/https_deposit.softwareheritage.org/hello_2.13.json

Loading...
View Options

swh/loader/package/deposit/tests/test_deposit.py

Loading...
About · Developer information · Legal